42046 - drag+drop for image works second time

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[sujay]

using 6/9 build of netscape

1) launch netscape
2) launch composer
3) insert image
4) drag and drop that image somewhere below the first image.

intially this doesn't work...but when you try it again the second time
it works.

all platforms.

Comment 1

[rubydoo123]

setting to m17

Comment 2

[sujay]

okay just talked to Kathy...the issue here is that if you click the image first
and then drag it, it works...but if you select it and then try dragging it
doesn'w work...

I feel either way shoulod work for the user...Beth can you approve having us
fix it so it works both ways?

Comment 3

[Kathleen :Brade]

add keyword nsbeta2; cc beppe

Comment 4

[leger]

Putting on [nsbeta2-] radar. Not critical to beta2.  Put on relnote keyword.

Comment 5

[rubydoo123]

pushing this one out to future

Comment 6

[rubydoo123]

adding help wanted keyword

Comment 7

[Syd Logan]

spam composer change

Comment 8

[rubydoo123]

removing myself from the cc list

Comment 9

[Kathleen :Brade]

Chris--I suspect this is related to our embedding customer's issue (616141).  I
think it's a core d&d issue or a core selection issue.  Will probably need some
cycles from mjudge to determine.

Comment 10

[saari (gone)]

topembed+, at least for investigation
->mjudge

Comment 11

[Kathleen :Brade]

Kin poked around enough to see that part of the problem is the code here needs
to be smarter:
http://lxr.mozilla.org/seamonkey/source/layout/html/base/src/nsFrame.cpp#1312

-->kin for now

Comment 12

[Kevin McCluskey (gone)]

editorbase+

Comment 13

[kinmoz]

Attachment: Patch Rev 1

This patch allows us to drag -moz-user-select:all, images and hrs on the mouse
down. The changes that enable this are in nsFrame.cpp. Also included in this
patch is a small change in nsHTMLDataTransfer.cpp that prevents the editor from
dropping content into the middle of -moz-user-select:all subtrees.

Comment 14

[kinmoz]

Attachment: Patch Rev 1.1

This patch is almost identical to patch rev 1, except it adds code that checks
to see if the user actually clicked within the bounds of a -moz-user-select:all
subtree. Apparently, in some cases, selection will hilite -moz-user-select:all
subrees even if you haven't clicked in it.

Comment 15

[kinmoz]

Attachment: Patch Rev 1.2

Same as previous patch except I moved:

+      rv = aRelativeView->GetParent(aRelativeView);
+      if (NS_FAILED(rv)) return PR_FALSE;

to the bottom of the while loop. Duh ... thanks for catching that mjudge.

Comment 16

[mjudge]

Comment on attachment 116878 [details] [diff] [review]
Patch Rev 1.2

looks good now

Comment 17

[kinmoz]

Patch Rev 1.2 checked into the TRUNK:

mozilla/layout/html/base/src/nsFrame.cpp              revision 3.427
mozilla/editor/libeditor/html/nsHTMLDataTransfer.cpp  revision 1.79

Comment 18

[kinmoz]

*** Bug 194280 has been marked as a duplicate of this bug. ***

Comment 19

[rubydoo123]

using trunk build from 2003040708 on win2K, this works fine. This is what I did:
1. opened new composer window
2. entered several lines of text
3. inserted image in first line of text
4. selected image and moved in several different locations via select & drag