420460 - [gnomestripe] Vista Aero theme changes broke gnomestripe

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[Bill Gianopoulos [:WG9s]]

The code checked in to fix bug 419319 changed theme elements which formerly had global definitions to now have separate 'luna' and aero' definitions.

Comment 1

[Bill Gianopoulos [:WG9s]]

Attachment: Workaraound

This is just wrong.  Having to specify the name of a Windows OS theme in order to override applications defaults in a Linux theme is just not right.

Comment 2

[Ian Spence]

I still don't understand why that isn't just being backed out.  They fixed a minor annoyance to help 3rd party themes (which there aren't that many of) just to break 1st party themes that are constantly being updated

Comment 3

[Bill Gianopoulos [:WG9s]]

Comment on attachment 306732 [details] [diff] [review]
Workaraound

Not much of a workaround.  It doesn't work.

Comment 4

[Bill Gianopoulos [:WG9s]]

Attachment: Workaround V2

This one works.  The other one kind of had 'luna' at the wrong point in the path.  This one also 'fixes' all 3 jar.mn files.

Comment 5

[Bill Gianopoulos [:WG9s]]

Comment on attachment 306757 [details] [diff] [review]
Workaround V2

This caused another regression.  New patch forthcoming.

Comment 6

[Bill Gianopoulos [:WG9s]]

Attachment: Workaround V3

I'm not sure why, but applying the same logic in browser resulted in the loss of bookmark icons being displayed.

Comment 7

[Mike Connor [:mconnor]]

I think, fwiw, replacing "luna" with "default" mitigates 90% of the weirdness.  The way we package our own themes feels like its pretty broken and limiting, need to figure out how to reswizzle this next cycle so we lose the fairly broken dependencies

Comment 8

[Bill Gianopoulos [:WG9s]]

Attachment: Workaround V4

OK.  I figured out what i did wrong last time with browser.  This fixes all three files.

Comment 9

[Bill Gianopoulos [:WG9s]]

(In reply to comment #7)
> I think, fwiw, replacing "luna" with "default" mitigates 90% of the weirdness. 
> The way we package our own themes feels like its pretty broken and limiting,
> need to figure out how to reswizzle this next cycle so we lose the fairly
> broken dependencies
> 
So, what is the correct course of action here?  Check this in and then change 'luna' to default' in all of themes in another bug?  Or, should we wait until the 'luna' to default' change and then check in a real fix here?

Comment 10

[Reed Loden [:reed]]

I have a patch to fix all this in bug 419319.

Comment 11

[Reed Loden [:reed]]

Fixed by patch in bug 419319.