42048 - Cancelling the file picker causes crash

Status: VERIFIED FIXED

(Core :: XUL, defect, P1)

Description

[Jeffrey Baker]

(note: the XP File Picker needs its own component)
(note: i strongly prefer my native file picker to the XP one)

On Linux build 2000060908 (M17), cancelling in the XP file picker causes a
segmentation fault.  To reproduce:

1) Start Moz
2) Pick "Save Page As" from the "File" menu
3) Close the file picker by clicking "Cancel", or using your platform's window
destruction widget.

Mozilla exits with a segmentation fault.  The nightly build is stripped so I
don't have a backtrace.  These are the dying gasps from the console:

-*- filepicker: CI: {c47de916-1dd1-11b2-8141-82507fa02b21}
-*- filepicker: IID:nsIFilePicker
nsIDOMWindow id value = {a6cf906b-15b3-11d2-932e-00805f8add32}
WEBSHELL+ = 5
WEBSHELL- = 4
./run-mozilla.sh: line 29:  3133 Segmentation fault      $prog ${1+"$@"}

Comment 1

[Jeffrey Baker]

Adding crash keyword

Comment 2

[Peter Trudelle]

adding dogfood keyword, assigning to pavlov

Comment 3

[leger]

Putting on [nsbeta2+][dogfood-] radar.  Does not need a fix ASAP for daily work, 
but we should fix this for beta2.

Comment 4

[Jeffrey Baker]

Changing status to assigned to bring this bug onto Bugzilla's default search
radar.

Comment 5

[Jeffrey Baker]

That is, will someone sufficiently empowered please change the status to
assigned.  Some day Gerv will give me some Bugzilla experience points :)

Comment 6

[Stuart Parmenter]

i havn't seen this since i checked in teh event queue love a week ago.  has
anyone else?

Comment 7

[John Morrison]

Yeah, I get this with today's build.

Comment 8

[Brian Ryner (not reading)]

I'll take this, since I have a fix.

Comment 9

[Brian Ryner (not reading)]

Attachment: Fix for bug

Comment 10

[Brian Ryner (not reading)]

Fix checked in.

Comment 11

[Jeffrey Baker]

Confirmed fixed on Linux build 2000061214 (M17).

Comment 12

[John Morrison]

Yep. verified. 

Comment 13

[Doron Rosenberg (IBM)]

*** Bug 42124 has been marked as a duplicate of this bug. ***

Comment 14

[Jeffrey Baker]

See bug 44975

Comment 15

[Daniel Veditz [:dveditz]]

Adding keyword to bugs which already show a nsbeta2 triage value in the status 
whiteboard so the queries don't get screwed up.