420537 - Remove unusable printAttachmentCmd strings

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Tb fix [checked in]

Bug 75691 added printAttachmentCmd.label and printAttachmentCmd.accesskey unused, but either due to a typo or as a hidden file joke, used ".Print" with a leading dot. Now we have about half the locales using a dot, and half not, so if someone ever implements attachment printing, the string will be unusable - it'll take a new name to get the dotted half to realize they should drop the dot, and even then it's not a sure thing. Better to just trash it, which will get everyone to start clean when someone does implement it.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: SM fix [checked in]

^

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 306831 [details] [diff] [review]
Tb fix [checked in]

Always good to clean up unused stuff! r=me

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 306831 [details] [diff] [review]
Tb fix [checked in]

mail/locales/en-US/chrome/messenger/msgHdrViewOverlay.dtd 1.12

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 306832 [details] [diff] [review]
SM fix [checked in]

suite/locales/en-US/chrome/mailnews/msgHdrViewOverlay.dtd 1.20

Comment 5

[Phil Ringnalda (:philor)]

(In reply to comment #0)
> unused, but either due to a typo or as a hidden file joke, used ".Print"

According to timeless, neither one: in the way-back days, that was actually the way to say that the string was currently unused. Makes me wonder if any others have survived.