420549 - Removing an engine shortly after adding it triggers NS_ASSERT

Status: RESOLVED FIXED

(Firefox :: Search, defect, P2)

Description

[:Gavin Sharp [email: [e-mail]]]

... because the lazy serialization timer is still pending, and when it fires, the engine is gone, and it doesn't know how to deal. We should cancel the pending timer if it's still running when we remove the engine.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The assert that's hit, fwiw: "Can't serialize: file doesn't exist!" at:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/search/nsSearchService.js&rev=1.109&mark=1948#1941

because the file was already removed in removeEngine().

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 3

[Asaf Romano (gone)]

Comment on attachment 306842 [details] [diff] [review]
patch

r=mano

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 306842 [details] [diff] [review]
patch

Simple fix to the search service API, very low risk. Needed for bug 420328's unit test.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306842 [details] [diff] [review]
patch

a1.9=beltzner

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.110