420569 - Remove all button icons from the Add-ons Manager in gnomestripe and winstripe

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Bill Gianopoulos [:WG9s]]

Since the removal of the Icon on the find updates button in the add-ons manager, the button is now significantly different in height that the other buttons.  This looks rather un-polished.

Comment 1

[Bill Gianopoulos [:WG9s]]

Nevermind.  I just realized this is only an issue because the other buttons have icons, but none of them are present by default, but were added by extensions.

-> INVALID

Comment 2

[Bill Gianopoulos [:WG9s]]

REOPENING.

This is an issue for Thunderbird as it displays the Install button by default.  The Icon should to be removed from the Install button as well I would think.

Comment 3

[Bill Gianopoulos [:WG9s]]

Attachment: Screenshot showing the issue

Comment 4

[Bill Gianopoulos [:WG9s]]

There does not appear to be a way to file an extension manager bug under Thunderbird. :-(

Comment 5

[Ian Spence]

Because it's not a Thunderbird bug, it's a toolkit bug

Comment 6

[Bill Gianopoulos [:WG9s]]

(In reply to comment #5)
> Because it's not a Thunderbird bug, it's a toolkit bug
> 
Exactly!

But for some odd reason there is no appropriate component that I can find under toolkit.

Comment 7

[Ian Spence]

One could argue it is merely a theme issue.  I'll try to get a patch up soonish

Comment 8

[Bill Gianopoulos [:WG9s]]

(In reply to comment #7)
> One could argue it is merely a theme issue.  I'll try to get a patch up soonish
> 

Well, there is no component that appears to be correct for filing theme issues that impact all toolkit applications either (although these seem to often be filed under "Toolkit:XUl Widgets").

This is an issue under Firefox also.  But, only if you set extensions.hideInstallButton to false.

Comment 9

[Reed Loden [:reed]]

beltzner/faaborg: can we just get rid of all these icons-on-buttons?

Comment 10

[Bill Gianopoulos [:WG9s]]

(In reply to comment #9)
> beltzner/faaborg: can we just get rid of all these icons-on-buttons?
> 

I would think that for consistency across the theme, the buttons which display on that line of the add-ons manager ("Install", "Find Updates", "Install Updates" and "Show Information") either should either all have icons or should all not have icons.

The current mix and match approach is kind of not really a theme.

Comment 11

[Dave Townsend [:mossop]]

I was under the impression that we were removing all button icons

Comment 12

[Michael Monreal [:micmon]]

For GNOME, we normally use button icons for a limited number of "stock" actions, meaning actions like "save" or "delete" which have a stock icon. Some app-specific icons also make sense, but only if they are not over-used. 

For the icons in the addons dialog I don't think icons would improve the usability. 

Comment 13

[Ian Spence]

Well the patch I wrote removed the icons, so I'm glad you guys feel that way.  Shall have it posted later tonight, currently in Windows

Comment 14

[Ian Spence]

Attachment: Removes icons from each button that goes at the bottom of that dialog

This removes the icons from each button in winstripe and gnomestripe.  pinstripe already beat us to it.

I'm hoping maybe Reed could enlighten me on the correct person to request review from, since we don't even know where this bug belongs to begin with

Comment 15

[Reed Loden [:reed]]

Comment on attachment 306949 [details] [diff] [review]
Removes icons from each button that goes at the bottom of that dialog

Mano can review this. :)

Comment 16

[Asaf Romano (gone)]

Comment on attachment 306949 [details] [diff] [review]
Removes icons from each button that goes at the bottom of that dialog

r=mano

Comment 17

[Reed Loden [:reed]]

Comment on attachment 306949 [details] [diff] [review]
Removes icons from each button that goes at the bottom of that dialog

Simple CSS removal to completely get rid of the icons-on-buttons to make UI clean. Also fixes an issue with icon height on products that use the Install button (not Firefox).

Comment 18

[Mike Beltzner [:beltzner, not reading bugmail]]

Not going to block beta 4 on this, and too late for a patch. We'll get it next time.

Comment 19

[Reed Loden [:reed]]

Comment on attachment 306949 [details] [diff] [review]
Removes icons from each button that goes at the bottom of that dialog

This is a blocker. No approval1.9 needed.

Comment 20

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.12; previous revision: 1.11
done
Checking in toolkit/themes/winstripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.29; previous revision: 1.28
done
Checking in toolkit/themes/winstripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.30; previous revision: 1.29
done
Removing toolkit/themes/winstripe/mozapps/extensions/actionbuttons.png;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/actionbuttons.png,v  <--  actionbuttons.png
new revision: delete; previous revision: 1.5
done
Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.46; previous revision: 1.45
done