Closed
Bug 420639
Opened 18 years ago
Closed 18 years ago
C++ comments in jsarray.c
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
References
Details
(Keywords: assertion, testcase)
Attachments
(1 file, 1 obsolete file)
|
937 bytes,
patch
|
igor
:
review+
igor
:
approval1.9b4+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #418737 +++
In the patch for bug 418737 I have used C++ comments:
static JSBool
array_enumerate(JSContext *cx, JSObject *obj, JSIterateOp enum_op,
jsval *statep, jsid *idp)
{
...
case JSENUMERATE_NEXT:
...
// FALL THROUGH
^^^^^^^^^^^^^^^
GCC rightfully complained about it:
/home/igor/m/ff/mozilla/js/src/jsarray.c:986:9: warning: C++ style comments are not allowed in ISO C90
Too bad I have not noticed the warning.
|
Assignee | |
Comment 2•18 years ago
|
||
I am not sure if a b4 approval for such patch (that fixes GCC warnings as well) is necessary.
Attachment #306948 -
Flags: approval1.9b4?
|
|
Assignee | |
Comment 3•18 years ago
|
||
Comment on attachment 306947 [details] [diff] [review]
v1
this is a duplicated attachment
Attachment #306947 -
Attachment is obsolete: true
Attachment #306947 -
Flags: review+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Comment on attachment 306948 [details] [diff] [review]
v1
Self review/approval as this is comment only change.
Attachment #306948 -
Flags: review+
Attachment #306948 -
Flags: approval1.9b4?
Attachment #306948 -
Flags: approval1.9b4+
|
|
Assignee | |
Comment 5•18 years ago
|
||
I checked in the patch from comment 2 to the trunk:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&cvsroot=%2Fcvsroot&date=explicit&mindate=1204504341&maxdate=1204504468&who=igor%25mir2.org
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•