420642 - Remove eval hack from XOWs

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

For bug 389878, I added a hack to always wrap the 'eval' function, even when we're same origin. Thanks to bug 397855, this hack isn't necessary anymore and we can remove it.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306954 [details] [diff] [review]
Fix

a1.9=beltzner

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in.

Comment 4

[Brendan Eich [:brendan]]

Over in bug 421571, Gavin fingered this as the regresses-gmail patch.

/be

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I've backed this out to fix bug 421571.

Comment 6

[jag (Peter Annema)]

Any ideas or theories why this caused bug 421571?

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Not yet. I'll look into it later this week.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Blake: How badly do we need this fixed? Can we simply leave things as is for FF3? Otherwise this should be nominated as a blocker.

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

This isn't important enough to block. It was just some code removal that I though I could get away with. Perhaps my "later this week" was a little optimistic.

Comment 10

[Brian Crowder]

Comment on attachment 306954 [details] [diff] [review]
Fix

Removing approval flag.  This can await post-1.9

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/232004a879d2

Comment 12

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 306954 [details] [diff] [review]
Fix

I'd like to get this in on 1.9.1 to ease other work.

Comment 13

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e7efbf0ea893