Closed Bug 420642 Opened 15 years ago Closed 14 years ago

Remove eval hack from XOWs

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta5

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

For bug 389878, I added a hack to always wrap the 'eval' function, even when we're same origin. Thanks to bug 397855, this hack isn't necessary anymore and we can remove it.
Attached patch FixSplinter Review
Attachment #306954 - Flags: superreview?(jst)
Attachment #306954 - Flags: review?(jst)
Attachment #306954 - Flags: superreview?(jst)
Attachment #306954 - Flags: superreview+
Attachment #306954 - Flags: review?(jst)
Attachment #306954 - Flags: review+
Attachment #306954 - Flags: approval1.9?
Comment on attachment 306954 [details] [diff] [review]
Fix

a1.9=beltzner
Attachment #306954 - Flags: approval1.9? → approval1.9+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9 → mozilla1.9beta5
Over in bug 421571, Gavin fingered this as the regresses-gmail patch.

/be
I've backed this out to fix bug 421571.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Any ideas or theories why this caused bug 421571?
Not yet. I'll look into it later this week.
Blake: How badly do we need this fixed? Can we simply leave things as is for FF3? Otherwise this should be nominated as a blocker.
This isn't important enough to block. It was just some code removal that I though I could get away with. Perhaps my "later this week" was a little optimistic.
Comment on attachment 306954 [details] [diff] [review]
Fix

Removing approval flag.  This can await post-1.9
Attachment #306954 - Flags: approval1.9+
http://hg.mozilla.org/mozilla-central/rev/232004a879d2
Status: REOPENED → RESOLVED
Closed: 15 years ago14 years ago
Resolution: --- → FIXED
Comment on attachment 306954 [details] [diff] [review]
Fix

I'd like to get this in on 1.9.1 to ease other work.
Attachment #306954 - Flags: approval1.9.1?
Attachment #306954 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.