Closed Bug 420707 Opened 12 years ago Closed 9 years ago

Remove MOZ_META_COMPONENT ifdef from config.mk

Categories

(Firefox Build System :: General, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
mozilla5

People

(Reporter: mcsmurf, Assigned: standard8)

References

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 file, 1 obsolete file)

The ifdef check for MOZ_META_COMPONENT under http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/config/config.mk&rev=3.387#288 should be removed as MOZ_META_COMPONENT is no longer defined anywhere. Also see http://mxr.mozilla.org/mozilla/search?string=MOZ_META_COMPONENT on this.
Attached patch Patch (obsolete) — Splinter Review
Attached patch Updated patchSplinter Review
I just stumbled across this and its sad to see a tidy up patch hanging around with nothing to do. From mxr this is quite clearly not necessary:

http://mxr.mozilla.org/comm-central/search?string=MOZ_META_COMPONENT

This patch updates the previous and adds the remaining cases where this is defined. I'll deal with the comm-central instance in a separate bug.
Assignee: nobody → bugzilla
Attachment #307028 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #520700 - Flags: review?(khuey)
Flags: in-testsuite-
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/5b36eb27a381
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
(In reply to comment #2)
> I'll deal with the comm-central instance in a separate bug.

Bug 643508.
Blocks: 643508
Blocks: 549291
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.