Closed Bug 420733 Opened 16 years ago Closed 16 years ago

Fix a couple instances of aaa:labelledby usage for accessibility.

Categories

(Firefox :: Settings UI, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: MarcoZ, Assigned: MarcoZ)

References

Details

(Keywords: access, regression)

Attachments

(1 file, 1 obsolete file)

When ARIA support was reworked to no longer support namespaced ARIA attributes, occurrances were overlooked on the Main and Privacy pages of the Preferences dialog. As a result, accessibility no longer reports correct labels for some controls.
Attached patch Fix up labelledby attribute. (obsolete) — Splinter Review
Attachment #307057 - Flags: review?
Attachment #307057 - Flags: review?(mano)
Attachment #307057 - Flags: review?(aaronleventhal)
Attachment #307057 - Flags: review?
Comment on attachment 307057 [details] [diff] [review]
Fix up labelledby attribute.

-              xmlns:aaa="http://www.w3.org/2005/07/aaa">

In privacy.xul removing the closing > when you remove xmlns. Other than that it looks good.
Attachment #307057 - Flags: review?(mano)
Attachment #307057 - Flags: review?(aaronleventhal)
Attachment #307057 - Flags: review-
Thanks for catching this!
Attachment #307057 - Attachment is obsolete: true
Attachment #307071 - Flags: review?(aaronleventhal)
Attachment #307071 - Flags: review?(aaronleventhal) → review+
Attachment #307071 - Flags: review?(mano)
Comment on attachment 307071 [details] [diff] [review]
Fix missing right tagging symbol

r=mano
Attachment #307071 - Flags: review?(mano) → review+
Attachment #307071 - Flags: approval1.9?
Comment on attachment 307071 [details] [diff] [review]
Fix missing right tagging symbol

a1.9+=damons
Attachment #307071 - Flags: approval1.9? → approval1.9+
checked in

Checking in browser/components/preferences/main.xul;
/cvsroot/mozilla/browser/components/preferences/main.xul,v  <--  main.xul
new revision: 1.17; previous revision: 1.16
done
Checking in browser/components/preferences/privacy.xul;
/cvsroot/mozilla/browser/components/preferences/privacy.xul,v  <--  privacy.xul
new revision: 1.26; previous revision: 1.25
done

Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: