Closed Bug 420750 Opened 16 years ago Closed 16 years ago

implement insertNewline: correctly

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file)

fix v1.0
1.15 KB, patch
masayuki
: review+
roc
: superreview+
damons
: approval1.9+
Details | Diff | Splinter Review
Attached patch fix v1.0 — — Splinter Review 
Right now we intercept insertNewline: commands and then leave the real insertNewline: unimplemented. We should just implement it correctly.
Attachment #307075 - Flags: review?(masayuki)
Attachment #307075 - Flags: review?(masayuki) → review+
Attachment #307075 - Flags: superreview?(roc)
Attachment #307075 - Flags: superreview?(roc) → superreview+
Attachment #307075 - Flags: approval1.9?
Comment on attachment 307075 [details] [diff] [review]
fix v1.0

a1.9+=damons

Safe refactoring per conversation w/ Josh.
Attachment #307075 - Flags: approval1.9? → approval1.9+
landed on trunk
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: