Populating jsinvoke.c with real code

RESOLVED WONTFIX

Status

()

Core
JavaScript Engine
--
enhancement
RESOLVED WONTFIX
10 years ago
9 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

Trunk
Points:
---
Bug Flags:
blocking1.9 -

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

10 years ago
+++ This bug was initially created as a clone of Bug #419969 +++

The bug 419969 split jsinterp.c into jsinterp.c and jsinvoke.c but that was done via preprocessor trickery that just included jsinterp.c from jsinvoke.c without moving the code into the new file. This was done to minimize merge conflicts with other changes.

It would be nice to move the code itself to jsinvoke.c when things stabilized.
Flags: blocking1.9?
Don't see this blocking the release as it's a nice to have.  Please re-nom if you disagree or there are other reasons I'm missing.  
Flags: blocking1.9? → blocking1.9-
(Assignee)

Comment 2

9 years ago
For maximum performance with MSVC it is important to keep all the interpreter-related code js jsinterp.cpp. So the preprocessor trickery must remain.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.