420904 - support for custom options for jsinterp.c when compiling jsshell.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Igor Bukanov]

+++ This bug was initially created as a clone of Bug #419969 +++

It would be nice to modify Makefile.ref and related build files to allow to  specify compilation options specific to jsinterp.c. It should allow to check the effects of various optimizations on the js_Interpret function.

Comment 1

[Igor Bukanov]

I do not have time for this for now.

Comment 2

[Mike Schroepfer]

Ted can you take this?

Comment 3

[(not currently active) Ted Mielczarek]

I don't really know the standalone Spidermonkey build system, but I can take a look.

Comment 4

[Igor Bukanov]

Attachment: what I use for testing

The patch patches SpiderMonkey's build files to treat jsinterp.c specially. In particular, for optimized build with GCC it passes -O3, not -Os, to the compiler. The patch also adds a support INTERP_XCFLAGS so extra jsinterp.c - specific files can be passed from the command line.

This works on Linux with GCC 4.1, but I have no idea what should be a good option for MSVC.

Comment 5

[(not currently active) Ted Mielczarek]

Igor: it looks like you have this in hand. I'll handle bug 420906.

Comment 6

[Igor Bukanov]

Attachment: v2

In the new patch I keep by default the interpreter optimizations at -Os not to deviate from browser builds.

Comment 7

[Igor Bukanov]

I checked in the patch from the comment 6 to the trunk:

Checking in js/src/Makefile.ref;
/cvsroot/mozilla/js/src/Makefile.ref,v  <--  Makefile.ref
new revision: 3.53; previous revision: 3.52
done
Checking in js/src/config.mk;
/cvsroot/mozilla/js/src/config.mk,v  <--  config.mk
new revision: 3.27; previous revision: 3.26
done
Checking in js/src/rules.mk;
/cvsroot/mozilla/js/src/rules.mk,v  <--  rules.mk
new revision: 3.16; previous revision: 3.15
done