42093 - [FIX]Window title displays wrong image type

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[chuckie]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; m16) Gecko/20000605
BuildID:    2000060508

The URL http://bugzilla.mozilla.org/showattachment.cgi?attach_id=8383 points to
a JPEG image, but in the title bar Mozilla shows "CGI Image"

Reproducible: Always
Steps to Reproduce:
1.Open http://bugzilla.mozilla.org/showattachment.cgi?attach_id=8383 in Mozilla.
2.Read Title bar

Actual Results:  Title Bar reads "CGI Image 396x212 pixels"	

Expected Results:  Title Bar should read "JPEG Image 396x212 pixels"

Comment 1

[Blake Ross]

hmm, i see that also--weird.  maybe it's getting confused by 
showattachment.cgi?   Don't know whose problem this would be, sending to parser 
for an initial look since I assume they're the ones who set the title in this 
case.

Comment 2

[rickg]

Waqar: can you please take a look. The parser doesn't set the window title -- it 
only reports a <title> if present, which is not the case here.

Comment 3

[waqar]

This bug has been marked "future" because the original netscape engineer working
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug,or if it blocks your work in some way
-- please attach your concern to the bug for reconsideration.

Comment 4

[waqar]

FOrgot to set the milestone.

Comment 5

[Blake Ross]

I disagree with the future marking...this isn't like other difficult-to-
reproduce or not easily visible bugs...I see this on all bugzilla attachment 
pages where the attachment is an image (i.e. 
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=5371), and i'm sure it 
occurs in other places also.  At least pass this around to other engineers who 
might have an idea here, please...

Comment 6

[Blake Ross]

*** Bug 53199 has been marked as a duplicate of this bug. ***

Comment 7

[bsharma]

updated qa contact.

Comment 8

[Jacek Piskozub]

Is this bug still valid? We now do not try to show the image type at all. 

Comment 9

[Neil Fraser]

Yes I think it is still valid.  If you want to save any of these CGI images, you
have absolutely no way of determining their filetype from Mozilla's info.  Is it
a GIF, JPEG or PNG?  That information is not available anywhere in Mozilla,
whereas even Netscape 1 provided it.

Another thing that Mozilla won't tell you anywhere is the size of the image in
bytes or kilobytes.  Instead one has to save it to disk, then look.  Ideally it
would say right on the title bar:
  GIF image 100x50 pixels (5kb)

Comment 10

[Kevin McCluskey (gone)]

bulk reassigning Waqar's bugs to Don.

Comment 11

[Christopher Hoess (gone)]

Not parser.

Comment 12

[Jeremy M. Dolan]

Now the title is:

filename.foo (Image 400x500 pixels)

It might be nice to bring back the image type, as that's kind of useful info
(specially JPEG vs GIF/PNG: "is it a lossy copy?"). I suggest:

filename.foo (JPEG image, 400x500 pixels)

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 14

[Boris Zbarsky [:bzbarsky]]

Taking bug.  reviews, anyone?  This essentially implements Jeremy's idea.  Show
"FOO" if the type is IMAGE/FOO otherwise show the whole mime type (this case
should never really be hit).

Comment 15

[Jeremy M. Dolan]

Looks good to me, though this isn't an official r=.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Attachment: Address some nits from timeless

Comment 17

[jag (Peter Annema)]

Comment on attachment 67851 [details] [diff] [review]
Address some nits from timeless

sr=jag

Comment 18

[Boris Zbarsky [:bzbarsky]]

checked in

Comment 19

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

should we perhaps strip "x-" as well from mimetypes like "image/x-icon"?

Comment 20

[Boris Zbarsky [:bzbarsky]]

Attachment: patch to strip out the "X-" if present

Ho-hum.  Forgot about those.  :)  Sicking, want to review?

Comment 21

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 68159 [details] [diff] [review]
patch to strip out the "X-" if present

r=sicking

Didn't think about those either until i saw the the image/x-icon mimetype

Comment 22

[jag (Peter Annema)]

Comment on attachment 68159 [details] [diff] [review]
patch to strip out the "X-" if present

sr=jag

Comment 23

[Boris Zbarsky [:bzbarsky]]

second patch checked in.

Comment 24

[Moied]

Marking verified fixed, checked in cvs