421018 - Fix checkin comment

Status: RESOLVED FIXED

(mozilla.org :: CVS: Administration, task)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=&branchtype=match&dir=mozilla%2Fxpcom&file=&filetype=match&who=bent.mozilla&whotype=regexp&sortby=Date&hours=2&date=explicit&mindate=2007-04-25&maxdate=2007-04-27&cvsroot=%2Fcvsroot

Should say:

Bug 377995 - "Move nsCategoryCache to the XPCOM Glue". nsCategoryCache was initially created as part of Bug 315598 by Christian Biesinger <[e-mail]>. r=bsmedberg.

(The change is the bug number, 37795 -> 377995)

Comment 1

[Dave Miller [:justdave]]

The two files at the bottom of that query... are those added files or removed files?

Comment 2

[Reed Loden [:reed]]

Removed... you would see a rev # if they were added.

Comment 3

[Jeremy Orem [:oremj]]

Any tips about changing the log message for a deleted file?

Comment 4

[Reed Loden [:reed]]

It's not really deleted. The files were just moved into the Attic subdirectory for that directory. Somebody should just patch fix-checkin-message to parse empty revisions as deleted files and add the needed "Attic/" into the path of the file.

So, instead of "/cvsroot/mozilla/xpcom/components/nsCategoryCache.h,v", the file is really at "/cvsroot/mozilla/xpcom/components/Attic/nsCategoryCache.h,v".

Comment 5

[Dave Miller [:justdave]]

The script doesn't touch raw RCS files, it uses cvs admin commands.  Which means it needs a copy of the file checked out in order to do anything to it.  This could be tricky.

Comment 6

[Dave Miller [:justdave]]

actually, as long as it has a working directory, it doesn't need an actual copy of the file, but it does need a revision number to apply the change to.

Comment 7

[Jeremy Orem [:oremj]]

Not sure which revision to use 1.1 didn't work.

Comment 8

[Dave Miller [:justdave]]

So a delete does get a revision number.  And if Bonsai's not showing it, there's no way we can get the rev number from a bonsai URL.  So files that are showing without a rev number will have to be entered manually in the script instead of being able to paste the bonsai URL in.  You can find the rev number by running 'cvs log' on the file in question in a local checkout and looking for the matching checkin with "State: dead" on it.  We can't do this programatically because ensuring a match means matching the commit message, and the script doesn't have the existing commit message yet at that point.  The script has been updated to be able to properly deal with editing the message on a delete checkin, because it wouldn't even touch the file previously.  However, this has exposed bug 375790 again (click the URL on this bug and you'll see what I mean).

The correction requested in this bug has been completed.  The remaining badness visible in Bonsai will have to be dealt with on bug 375790.

Comment 9

[Dave Miller [:justdave]]

Checking in fix-checkin-message;
/cvsroot/mozilla/tools/cvsmgmt/fix-checkin-message,v  <--  fix-checkin-message
new revision: 1.5; previous revision: 1.4
done

Comment 10

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Thanks guys. Sorry this was such a PITA...