Closed Bug 421135 Opened 15 years ago Closed 15 years ago

gfxAtsuiFonts.cpp:750: warning: statement has no effect

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: benjamin, Assigned: jtd)

References

(
URL
)

Details

Attachments

(1 file)

patch, fix typo
1.00 KB, patch
vlad
: review+
vlad
: superreview+
vlad
: approval1.9+
Details | Diff | Splinter Review 
gfxAtsuiFonts.cpp:750: warning: statement has no effect

I'm pretty certain this should be = not ==... not sure what effect this has in practice, but it looks like mLastPrefFirstFont would never get set. Marking blocking to make sure we're not losing something imporant.
Flags: blocking1.9?
Attached patch patch, fix typo — — Splinter Review 
Yeah, I spotted that this week, don't know how that snuck in.  Doesn't affect correctness but will make pref font matching slightly sub-optimal.
Assignee: nobody → jdaggett
Status: NEW → ASSIGNED
Attachment #307614 - Flags: superreview?(vladimir)
Attachment #307614 - Flags: review?(vladimir)
Attachment #307614 - Flags: superreview?(vladimir)
Attachment #307614 - Flags: superreview+
Attachment #307614 - Flags: review?(vladimir)
Attachment #307614 - Flags: review+
Attachment #307614 - Flags: approval1.9+
checked in
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.