Closed
Bug 421161
Opened 16 years ago
Closed 16 years ago
no image found
Categories
(Websites Graveyard :: spreadfirefox.com, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: graphicsguru, Assigned: cpollett)
References
()
Details
Attachments
(3 files)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12 Build Identifier: spreadfirefox with firefox it will just show a transparent image "png" on other browsers it will show image with a "x" found it testing the site in ie with a new account Reproducible: Always Steps to Reproduce: 1. 2. 3. paul bug or image has the wrong path or not loaded 2 new png images email to you
Comment 3•16 years ago
|
||
Please would you review the following patch which makes changes to the sfx_affiliates module to pick up the "sfx page" image (thanks Jamey) Please let me know if i can commit the image and changes to the sfx_affiliates module. Thanks Paul
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 4•16 years ago
|
||
Attachment #308621 -
Flags: review?(morgamic)
Updated•16 years ago
|
Assignee: ian-bugzilla → server-ops
Updated•16 years ago
|
Assignee: server-ops → aravind
Comment 5•16 years ago
|
||
Any problems with the patch ?
Comment 7•16 years ago
|
||
patch looks good to me, as long as you assume that you check the image into the correct location.
Updated•16 years ago
|
Priority: -- → P1
Comment 9•16 years ago
|
||
Comment on attachment 308621 [details] [diff] [review] sfx_affiliates patch Looks fine -- did you add /sites/all/themes/spreadfirefox_RCS/avatar_sfx_tiny.png to SVN? Don't forget to svn add it.
Attachment #308621 -
Flags: review?(morgamic) → review+
Updated•16 years ago
|
Assignee: ian-bugzilla → paul
Comment 10•16 years ago
|
||
Hi Micheal, I have committed the patch and the graphic . Please push these to production. Thanks Paul
Assignee: paul → morgamic
Comment 11•16 years ago
|
||
Hey Paul -- any reason why we cannot see these on https://sfx.stage.mozilla.com/ ? I've confirmed that they are in SVN. 137:~/Code/spreadfirefox.com/trunk/sites/all/themes/spreadfirefox_RCS polvi$ svn up avatar_sfx_tiny.png A avatar_sfx_tiny.png Updated to revision 12351. 137:~/Code/spreadfirefox.com/trunk/modules/sfx/sfx_affiliates polvi$ svn up sfx_affiliates.module C sfx_affiliates.module Updated to revision 12351. -Alex
Comment 12•16 years ago
|
||
Hi Alex I'll investigate when i come back online shortly -Paul
Comment 13•16 years ago
|
||
You will see these changes tomorrow after our daily scheduled cron.php runs. Please don't run this now though Alex as it has to run every 24 hours . I'll resolve this as fixed tomorrow if all goes well. -Paul
Comment 14•16 years ago
|
||
Hi Alex . I don't see the new graphic on the "Top 250 Affiliates" page on the production server today because both the changes to the sfx_affiliates.module and the new graphic have not reached the production server. My commited changes are in subversion http://viewvc.svn.mozilla.org/vc/projects/spreadfirefox.com/trunk/modules/sfx/sfx_affiliates/sfx_affiliates.module?view=markup http://viewvc.svn.mozilla.org/vc/projects/spreadfirefox.com/trunk/sites/all/themes/spreadfirefox_RCS/avatar_sfx_tiny.png?view=markup and i can see the the new graphic on the staging server https://sfx.stage.mozilla.com/sites/all/themes/spreadfirefox_RCS/avatar_sfx_tiny.png Would you please help me to investigate. Thanks Paul
Updated•16 years ago
|
Assignee: morgamic → cpollett
Comment 15•16 years ago
|
||
This is now resolved. Thanks Paul
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Status: RESOLVED → VERIFIED
Updated•13 years ago
|
Product: Websites → Websites Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•