421281 - profiling script should error if application errors

Status: NEW

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Currently the Python profiling script does not exit with an error code if the application does, so the build will continue on to the second build pass, which is bogus. It should error with whatever error code the application returns. (Split off from bug 420187 which is now about the hang the Win32 tinderbox was experiencing.)

Comment 1

[Robert Sayre]

Attachment: exit code

Comment 2

[Robert Sayre]

Attachment: return the status

Comment 3

[Damon Sicore (:damons)]

Comment on attachment 308212 [details] [diff] [review]
return the status

a1.9+=damons

Comment 4

[Kai Engert (:KaiE:)]

Should this get checked in?

Comment 5

[(not currently active) Ted Mielczarek]

Rob: this hasn't bitrotted, has it?

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 308212 [details] [diff] [review]
return the status

We fixed the hang, so this isn't urgent. We can take this in 3.next or whatever.

Comment 7

[Gregory Szorc [:gps]]

I think this is still a relevant bug because I recall filing a bug about profileserver.py not handling errors sometime in the past ~18 months. Unfortunately, I can't find said bug...