421314 - VC 2005 warnings need fixing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Mike Moening]

Attachment: VC 2005 warnings fix V1

There are a couple of small VC 2005 compiler warnings that need fixin.

Comment 1

[Igor Bukanov]

Comment on attachment 307738 [details] [diff] [review]
VC 2005 warnings fix V1

>Index: jsxml.c
>-    JS_CHECK_RECURSION(cx, return JS_FALSE);
>+    JS_CHECK_RECURSION(cx, return NULL);

I wish GCC can do the same ...

>-        arenaList->lastCount = THINGS_PER_ARENA(thingSize);
>+        arenaList->lastCount = (uint16)THINGS_PER_ARENA(thingSize);
...

>-                    arenaList->lastCount = indexLimit;
>+                    arenaList->lastCount = (uint16)indexLimit;

Style nit: please add a blank after the cast operator so the code looks like:
    
    (uint16) x;

and *not* like
 
    (uint16)x;

r+ with the nits fixed.

Comment 2

[Mike Moening]

I can do that but there are plenty of other examples right in that area that don't have a space after the cast operator.
Let me know...

Comment 3

[Igor Bukanov]

(In reply to comment #2)
> I can do that but there are plenty of other examples right in that area that
> don't have a space after the cast operator.
> Let me know...

That was style violations (by me in this case). Lets not add new examples.

Comment 4

[Mike Moening]

Attachment: VC 2005 warnings fix V2

Fixed your nit and other examples of bad style nearby.
After your r+ how do I land this?
Can I just check it in?
I've never tried. :-)

Comment 5

[Mike Moening]

>I wish GCC can do the same ...
Windows gets lots of bashing but man I love the VC 2005 compiler/IDE.
It's just so slick.
Now if I could only convince Ben S. to help me compile firefox via VC 2005 IDE then I'd be set! Command line builds are not fun for me.

Comment 6

[Igor Bukanov]

Comment on attachment 307739 [details] [diff] [review]
VC 2005 warnings fix V2

Asking for 1.9 approval as this fixes compilation warning noise.

Comment 7

[Igor Bukanov]

(In reply to comment #4)
> After your r+ how do I land this?

After getting r+ one has to ask for an approval flag for the patch. Alternatively one can ask for blocking1.9 on the bug itself if it is essential that the bug must be addressed before FF3 release.

This extra steps is a consequence of the beta phase for FF3.

> Can I just check it in?

If you have necessary permissions, then cvs ci would do the job. Otherwise just ask in the bug for landing. For that just add to Whiteboard field (the one between the Keywords and URL fields) for the bug the following text:

[need check-in]




> I've never tried. :-)
> 

Comment 8

[Mike Moening]

I guess I can't commit yet.
Got this when I tried:

cvs [server aborted]: "commit" requires write access to the repository

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 307739 [details] [diff] [review]
VC 2005 warnings fix V2

a1.9=beltzner

Comment 10

[Igor Bukanov]

I checked in the patch from the comment 4 to the trunk:

Checking in jsgc.c;
/cvsroot/mozilla/js/src/jsgc.c,v  <--  jsgc.c
new revision: 3.287; previous revision: 3.286
done
Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.197; previous revision: 3.196
done

To Mike Moening: thanks for reporting and *fixing* this!