Closed Bug 421345 Opened 16 years ago Closed 16 years ago

please QA the Customization page on the new Mozilla.com

Categories

(www.mozilla.org :: General, defect)

Product:
www.mozilla.org
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jslater, Assigned: stephend)

References

(
URL
)

Details

Attachments

(2 files)

Screenshot of IE 6 layout issue
198.35 KB, image/png
Details
Screenshot showing broken footer in IE 6
133.32 KB, image/png
Details 
Hi Stephen. Please QA as discussed. Also, we should have final art to replace the FPO illustrations soon (note: although not marked as such, the main header illustration is also FPO).

Thanks,
John
Target Milestone: --- → 3.0
1) As on the other templates, the right navigation area isn't populated (https://www-firefox3.stage.mozilla.com/en-US/products/firefox/ has the right links)
2) Broken IE 6 rendering; screenshot to follow

(Page validates and passes JavaScript-disabled tests.)
IE6 rendering fixed in r11178. Navigation should be there now - can you confirm?
1) Navigation is back, but the link to /customization isn't working; it should be /addons, I think
2) The footer is really broken in IE 6 (I verified bug 421344 because the footer is really a separate area/fix).  I'll attach a screenshot.
"There are more then 5,000 Add-ons" -> "There are more than 5,000 Add-ons"

(also not sure why we're capitalizing add-ons everywhere now; I assume it's intentional though)
Broken footer fixed in r11221.

> "There are more then 5,000 Add-ons" -> "There are more than 5,000 Add-ons"
Fixed in r11222.

/customization links changed to /addons in r11223.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
3) IE 6 has this weird bug where the first time you load a given page that includes the side-navigation area, it won't display; a refresh fixes it.  I don't know if there's a workaround or not for this first-time viewing issue.
4) The "See All Add-ons" link is empty; probably should be https://addons.mozilla.org/en-US/firefox/.

Page validates (yay), and is fine when JavaScript is disabled, too; Marco, are there any accessibility issues lurking?

4. agreed re: that link, thanks Stephen
Reopening, I see a bunch of issues on this page I want to see fixed before localization
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
<a href="https://en-us.add-ons.mozilla.com/en-US/firefox/">
this should be <a href="https://<?=$lang?>.add-ons.mozilla.com/<?=$lang?>/firefox/">

The above should be the case for all links to AMO to redirect users to their localized version of AMO if it exists, to their fallback preferred locale if not.

"Keep an eye on your eBay trading whenever you are on the Web" -> this extension is tied to specific geographic territories, namely the US/UK/FR/DE/IT countries. Maybe not the best add-on to promote worldwide.

Why are we using the old javascript script to display a download box on this page ? We have no use of locale detection there since we are proposing locale targeted content and text strings for localization shouldn't be in the middle of javascript code. It should be a php call to rcreate a box for firefox for the locale.

I checked some of the add-ons proposed, none of them is compatible with Firefox 3. Are we sure that these addons will be firefox 3 compatible the day of the release?


<li><a href="/<?=$lang?>/firefox/tips/">Tips &amp; Tricks</a></li>

This page does not exists and I never heard of it. If we link to a Tips page, it should be localized too.



<p>Make Firefox Your Own <span><a href="">See all Add-ons</a></span></p>
the url for the link is missing.
Adding a few notes to Pascal's comment:

(In reply to comment #12)
> "Keep an eye on your eBay trading whenever you are on the Web" -> this
> extension is tied to specific geographic territories, namely the US/UK/FR/DE/IT
> countries. Maybe not the best add-on to promote worldwide.
Is there an alternate extension we could promote outside of North America & Europe? I feel like the eBay one has a lot of value for a lot of reasons and would hate to cast it aside if there's another solution. David, you know the most about how and where eBay was promoted...any thoughts?

> I checked some of the add-ons proposed, none of them is compatible with Firefox
> 3. Are we sure that these addons will be firefox 3 compatible the day of the
> release?
Polvi, can you confirm that eBay, FoxyTunes, StumbleUpon & the NASA Night Launch theme will be compatible with FF3 in time for launch?

> <li><a href="/<?=$lang?>/firefox/tips/">Tips &amp; Tricks</a></li>
> This page does not exists and I never heard of it. If we link to a Tips page,
> it should be localized too.
This is one of the new pages that's being added as part of the redesign. It's not on staging yet, but it was on the list of pages I sent you a few weeks ago. It has screenshots and lots of text and I don't think it's a mission-critical page so my suggestion would be to make it optional for the localizers. If it's not localized (or is localized after the launch) it's not a huge deal.

Thanks,
John
Re: eBay locales:
Currently it is US/FR/DE/UK (and we have only promoted it in those locales), but we are hoping to roll it out to other European countries as well as S. America sometime in the next few months.

Also, the eBay companion will be Firefox 3 compatible. 
Pascal, let me know what you think about my comments in item #13 above. In particular, it seems like the vast majority of add-ons (whether they're mentioned on this page or not) aren't fully localized for the world. Correct me if I'm wrong, but that's my understanding.

If I'm correct, does that mean we should proceed with the localization of this page as is, with the understanding that there's no way to avoid English content? or, would it be better to not localize this page at all and reference a different page instead? It's totally your call, of course...just let us know how we should proceed.

Thanks,
John
Another note on eBay localization -- the companion should support any country and all eBay sites.  It'll default to English right now, but language support for other locales is coming soon.  
(In reply to comment #13)
> Adding a few notes to Pascal's comment:
> 
> (In reply to comment #12)
> > "Keep an eye on your eBay trading whenever you are on the Web" -> this
> > extension is tied to specific geographic territories, namely the US/UK/FR/DE/IT
> > countries. Maybe not the best add-on to promote worldwide.
> Is there an alternate extension we could promote outside of North America &
> Europe? I feel like the eBay one has a lot of value for a lot of reasons and
> would hate to cast it aside if there's another solution. David, you know the
> most about how and where eBay was promoted...any thoughts?
> 
> > I checked some of the add-ons proposed, none of them is compatible with Firefox
> > 3. Are we sure that these addons will be firefox 3 compatible the day of the
> > release?
> Polvi, can you confirm that eBay, FoxyTunes, StumbleUpon & the NASA Night
> Launch theme will be compatible with FF3 in time for launch?


Sorry for the delay.

Ebay - OK ala rolo
FoxyTunes - in progress, should be ready, see bug 411820
StumbleUpon - seems happy, https://addons.mozilla.org/en-US/firefox/addon/138
Nasa Night Launch - seems happy as well, https://addons.mozilla.org/en-US/firefox/addon/4908
since Alex confirmed that the add-ons will be updated on time, the only issues left are the links (missing or incorrect) and the javascript code that should be replaced by a php call. Could these minor issues be fixed rapidly so as that I can give this page for localization ?

Just in case, here is the php code for a per locale download box :

<?php echo $firefoxDetails->getDownloadBlockForLocale('es-ES', array('ancillary_links' => false)); ?>

Thanks
We're still using download.old.js on mozilla.com en-US pages because it provides browser-locale detection.  The PHP code in comment #18 will display a download button for es-ES only.  The code currently on the page will display a download button for whatever locale the user's browser is sending.

We should keep the current code on en-US and put the PHP on localized pages (although ancillary_links should be true).
Given Wil's comments - https://bugzilla.mozilla.org/show_bug.cgi?id=421345#c19 - can we resolve this bug?
(In reply to comment #20)
> Given Wil's comments - https://bugzilla.mozilla.org/show_bug.cgi?id=421345#c19
> - can we resolve this bug?

Fine with me; Wil or Pascal can file a spinoff bug about ancillary_links, if need be...
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Reopening, Pascal's missing-URL comment in comment 12 still applies:

<p>Make Firefox Your Own <span><a href="">See all Add-ons</a></span></p>
the url for the link is missing.

Steven, while this is reopened, can you link the add-on icons to their AMO page?  Similarly, how about linking the images for the categories on their left to their respective AMO pages?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
all addons should use the ab-CD.add-ons.mozilla.com/ab-CD/ scheme
I've updated all of the Add-ons urls on this page to use the proper scheme (r12216).
I've linked the add-on logos to the AMO pages (r12217). However, I haven't linked the category items to the category pages as this would require some changes to the pay structure (those are background images right now). If it's important, can we spin that out into it's own bug?
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
(In reply to comment #25)
> If it's
> important, can we spin that out into it's own bug?
Yeah, let's make a separate bug for that if it really needs to happen.

Looks good except for the 7 validation errors.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to comment #27)
> Looks good except for the 7 validation errors.

Fixed in r12254.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Verified FIXED.
Status: RESOLVED → VERIFIED
Component: www.mozilla.org/firefox → www.mozilla.org
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: