421391 - Use ssl3_AppendHandshakeNumber to send a zero-length SID

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Wan-Teh Chang]

In ssl3_SendClientHello and ssl3_SendServerHello, we use the
following code to send the SID:

    if (sid)
        rv = ssl3_AppendHandshakeVariable(
            ss, sid->u.ssl3.sessionID, sid->u.ssl3.sessionIDLength, 1);
    else
        rv = ssl3_AppendHandshakeVariable(ss, NULL, 0, 1);

If sid is NULL, or sid->u.ssl3.sessionIDLength is 0, we could send
it more efficiently with

        rv = ssl3_AppendHandshakeNumber(ss, 0, 1);

than with

        rv = ssl3_AppendHandshakeVariable(ss, NULL, 0, 1);

This change was made to ssl3_SendServerHello in the original TLS
session ticket patch, but was backed out in the last minute.  Nelson
would like us to put the change back in and also make the change to
ssl3_SendClientHello.

Comment 1

[:Cykesiopka]

Attachment: bug421391_v1.patch

Comment 2

[Ryan Sleevi]

Comment on attachment 8420580 [details] [diff] [review]
bug421391_v1.patch

Review of attachment 8420580 [details] [diff] [review]:
-----------------------------------------------------------------

r=ryan.sleevi

Comment 3

[Wan-Teh Chang]

Patch checked in: https://hg.mozilla.org/projects/nss/rev/801441d4bab0