421404 - [FIX]Gmail triggers "ASSERTION: Doing nscoord addition with values > nscoord_MAX"

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Load https://mail.google.com/mail/ (you must be logged in)

Result:

###!!! ASSERTION: Doing nscoord addition with values > nscoord_MAX: 'a < nscoord_MAX && b < nscoord_MAX', file ../../dist/include/gfx/nsCoord.h, line 150

WARNING: nscoord addition capped to nscoord_MAX: '(PRInt64)a + (PRInt64)b < (PRInt64)nscoord_MAX', file ../../dist/include/gfx/nsCoord.h, line 156

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Seems to do the trick

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 307836 [details] [diff] [review]
Seems to do the trick

Looks good to me, with this exception in the crashtest:

+<div style="width: -moz-fit-content; width: fit-content; clear: both">
(occurs 3 times)

You've got two "width" values on that outer div, and the second one ("fit-content") makes my CSS parser sad.  This is the error I get:
 "CSS Error (file:///home/dholbert/Desktop/foo.html :0.44): Error in parsing value for property 'width'.  Declaration dropped."

I'm guessing you just want the -moz-fit-content value, probably...?

r=dholbert with that fixed (or with an explanation for why it is the way it is)

Comment 3

[Boris Zbarsky [:bzbarsky]]

That's there so that whenever that part of CSS3 becomes a rec and we rename our implementation to fit-content the test will continue to work.

Comment 4

[Daniel Holbert [:dholbert]]

Ok, cool, I figured it was probably something like that.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 307836 [details] [diff] [review]
Seems to do the trick

Simple fix to avoid ending up with lengths larger than "infinity" in some cases.  this should be pretty safe.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 307836 [details] [diff] [review]
Seems to do the trick

a1.9=beltzner

Comment 7

[Peter van der Woude [:Peter6]]

Should this bug fix Gmail navigation being completely broken ?
e.g. [Chat] and [Labels] remain collapsed
Unable to navigate to outbox etc.

Comment 8

[Peter van der Woude [:Peter6]]

I filed Bug 421571 for the above mentioned issue, feel free to dupe it if needed

Comment 9

[Boris Zbarsky [:bzbarsky]]

> Should this bug fix Gmail navigation being completely broken ?

Doubt it, since this bug's existence predates the regression range in bug 421571.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Checked in.