421410 - selected text in input box is cleared/unselected after print preview

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[Wayne Mery (:wsmwk)]

selected text in input box is cleared/unselected after printing (print preview is OK)

1. select any text typed into bugzilla description field
2. file|print 

Expected results:
text still selected

Actual results:
text selection has been cleared/unselected

Similar to Bug 304313 - selected text cleared/unselected after print preview. So perhaps whatever was used to fix that would help this?

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008030506 Minefield/3.0b5pre

Comment 1

[Martijn Wargers (dead)]

This happens because the focus isn't returned to the text input after print preview, see discussion in bug 128953 as to why you don't see a selection when the input is blurred.
So this bug is basically about "Focus isn't returned to the element that had focus before print preview".

Comment 2

[Martijn Wargers (dead)]

And that should probably be fixed somewhere around here:
http://lxr.mozilla.org/seamonkey/source/toolkit/components/printing/content/printUtils.js#261

Comment 3

[Martijn Wargers (dead)]

Oops, I misread the bug, it's actually working for you for print preview, which is strange, because it's not working for me on print preview, but it's working fine for me with printing.

Comment 4

[Wayne Mery (:wsmwk)]

yeah, odd. I thought I was pretty careful in writing it up - but what I'm seeing now is what you say.  So I got it backward - print OK, preview not.

interesting when using _print_ if a dialog is not not on screen - the intitial print dialog and the progress dialog- then the selection is visible but when dialog is up the selection is not visible - is that what you are saying in comment 1?

Comment 5

[Martijn Wargers (dead)]

Yeah, that's what I was saying (sort of). The selection of text controls is made invisible when the focus moves away from it.

Comment 6

[Martijn Wargers (dead)]

Attachment: patch

This fixes it. It basically makes use of the code in bug 323805.
I couldn't find a Seamonkey version of printUtils.js, perhaps it uses the same file, I don't know.

I guess it might be better if gFocusedElement is a member of PrintUtils, right?

Comment 7

[Neil Deakin]

Comment on attachment 308024 [details] [diff] [review]
patch

Seems OK

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 308024 [details] [diff] [review]
patch

a1.9=beltzner

Comment 9

[Reed Loden [:reed] (use needinfo?)]

Checking in toolkit/components/printing/content/printUtils.js;
/cvsroot/mozilla/toolkit/components/printing/content/printUtils.js,v  <--  printUtils.js
new revision: 1.31; previous revision: 1.30
done