421495 - Startup error in Turkish Sunbird/lightning 0.8; timezone guessing is broken

Status: VERIFIED FIXED

(Mozilla Localizations :: tr / Turkish, defect)

Description

[Andreas Treumann]

Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.8.1.13pre) Gecko/20080305
Sunbird/0.8

Error: Skipping locale timezone 'Amerika/New_York'. TypeError: tz has no properties
Source File: chrome://calendar/content/calUtils.js
Line: 660

The error happens because the string "likelyTimezone" has been translated:
http://mxr.mozilla.org/l10n-mozilla1.8/source/tr/calendar/chrome/calendar/calendar.properties#

but must be in English:

http://mxr.mozilla.org/mozilla1.8/source/calendar/locales/en-US/chrome/calendar/calendar.properties#214
# LOCALIZATION NOTE (likelyTimezone):
#   Translators, please put the most likely timezone(s) where the people using
#   your locale will be.  Use the Olson ZoneInfo timezone name *in English*,

Comment 1

[Ahmet Serkan Tıratacı]

I guess this's the fix:

http://mxr.mozilla.org/l10n-mozilla1.8/source/tr/calendar/chrome/calendar/calendar.properties#196

- likelyTimezone=Amerika/New_York
+ likelyTimezone=Europe/Istanbul

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v1

I'd agree with Europe/Istanbul.

Comment 3

[Stefan Sitter [:ssitter]]

Yes, Europe/Istanbul should work. See the localization note linked likelyTimezone from Comment #0 for details in case you want to specify more than one timezones.

Please note that we already switched the tinderbox to release preparation mode. This means you will have to submit your changes to SUNBIRD_0_8_BRANCH as well to take effect. http://groups.google.com/group/mozilla.dev.l10n/msg/1d11a4a12be3062d

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Error still occurs in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; tr; rv:1.8.1.13pre) Gecko/20080311 Sunbird/0.8

Patch still needs to be checked in to trunk / 1.8 branch / SB 0.8 branch.

Comment 5

[Ahmet Serkan Tıratacı]

Erkan has just fixed this on MOZILLA_1_8_BRANCH and on trunk. However, we haven't been able to do so on SB 0.8 branch.

Comment 6

[Stefan Sitter [:ssitter]]

Please checkin the change to SUNBIRD_0_8_BRANCH too.

Comment 7

[Daniel Boelzle [:dbo]]

(In reply to comment #5)
Ahmet, what has been the problem?

Comment 8

[Simon Paquet [:sipaq]]

Erkan, your recent checkin to calendar.properties is wrong. You used "Europa/Istanbul" as timezone, while you should have used "Europe/Istanbul".

The timezone name in calendar.properties *MUST* not be translated.

Comment 9

[Matthew (lilmatt) Willis]

lilmatt-mbp:/work/moz/l10n/l10n lilmatt$ cvs commit -m "Bug 421495 - Fix Turkish likelyTimezone." -rSUNBIRD_0_8_BRANCH tr/calendar/chrome/calendar/calendar.properties
Checking in tr/calendar/chrome/calendar/calendar.properties;
/l10n/l10n/tr/calendar/chrome/calendar/calendar.properties,v  <--  calendar.properties
new revision: 1.1.2.4.2.2; previous revision: 1.1.2.4.2.1
done

Europa -> Europe fix landed on SUNBIRD_0_8_BRANCH.  MOZILLA_1_8_BRANCH and trunk were already correct.

-> FIXED

Comment 10

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Verifying.