With --disable-xpconnect-idispatch --disable-accessibility, link errors in libxul

RESOLVED FIXED in mozilla1.9beta5

Status

()

Core
Build Config
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

Trunk
mozilla1.9beta5
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 307960 [details] [diff] [review]
link oleaut32 explicitly, rev. 1

When you disable code that uses ATL (because the newest MS SDKs don't come with ATL headers any more), libxul fails to link because it doesn't pick up necessary symbols from oleaut32.
Attachment #307960 - Flags: review?(ted.mielczarek)
Attachment #307960 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 1

10 years ago
Comment on attachment 307960 [details] [diff] [review]
link oleaut32 explicitly, rev. 1

Very low risk
Attachment #307960 - Flags: approval1.9?
Comment on attachment 307960 [details] [diff] [review]
link oleaut32 explicitly, rev. 1

a1.9+=damons
Attachment #307960 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Checking in toolkit/library/libxul-rules.mk;
/cvsroot/mozilla/toolkit/library/libxul-rules.mk,v  <--  libxul-rules.mk
new revision: 1.28; previous revision: 1.27
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta5
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.