421539 - DOMLinkRemoved code confuses DEBUG_CC

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

As I described in bug 420548 comment 0:

# http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/content/html/content/src/nsHTMLLinkElement.cpp&rev=1.93&mark=246-250#236
# keeps any link elements alive for some additional time after the cycle
# collector thinks they ought to go away.  This confuses the cycle collector
# debugging code in other ways too, since it causes this warning:
# 
# nsCycleCollector: nsGenericElement object @0x1c50ff0 is still alive after
#   calling RootAndUnlinkJSObjects, Unlink, and Unroot on it!  This probably
#   means the Unlink implementation was insufficient.
# 
# to be printed as well.

I suspect that in most (maybe all?) cases where this warning would be printed, there wouldn't be any useful document to dispatch the event to once the nsPLDOMEvent was posted; maybe something should keep track of posted nsPLDOMEvents and revoke those that are going to be unneeded (or already known to be at time of posting).  I'm not really sure if it's worth fixing, but it might be needed if we want to get DEBUG_CC warning-free.

Comment 1

[Andrew McCreight [:mccr8]]

I removed this code from DEBUG_CC, and anyways DEBUG_CC is going away entirely in bug 845441.