421626 - Fix packaging on OS/2

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Peter Weilbacher]

When running make package in the OBJDIR I see warnings about missing shlibsign (similar to bug 370693) and the binaries are not stripped any more.

The latter should be easily fixed by using the old strip.cmd (that existed in xpinstall/packager/os2 not too long ago) in toolkit/mozapps/installer/os2. The former is a bit more difficult. Running shlibsign.exe won't work, even when fixing the file extension using $(BIN_SUFFIX), because it depends on DLLs in dist/bin. So the best solution would probably be to use a script like security/nss/cmd/shlibsign/sign.cmd and adapt it for this purpose.

Comment 1

[Peter Weilbacher]

Attachment: this works

With this I get nicely stripped packages where the NSS DLLs are correctly re-signed after stripping.

Comment 2

[Peter Weilbacher]

Fix checked into trunk. Actually without the added $(BIN_SUFFIX) which was a leftover from a previous version of my patch, I didn't intend to touch at all what other platforms do.

Comment 3

[Walter Meinl]

I never posted to this bug though being cc'd cause I struggled with strip.cmd seeming not to do what it should. I found out that lxlite doesn't seem to work properly when its called from 4os2. (I didn't have problems using 4os2 with sign.cmd or other rexx cmd files we use).
After putting a comspec setting in my setmozenv.cmd pointing to os2\cmd.exe it works now and strip.cmd gives us really nicely stripped exes and dlls.
This means that we don't need an OS/2 follow up for bug389781 (which I have on my watchlist).
I encounter however one problem with checkout
cvs checkout: move away mozilla/toolkit/mozapps/installer/os2/sign.cmd; it is in the way
C mozilla/toolkit/mozapps/installer/os2/sign.cmd
cvs checkout: move away mozilla/toolkit/mozapps/installer/os2/strip.cmd; it is in the way
C mozilla/toolkit/mozapps/installer/os2/strip.cmd
I did remove them of course but the next time I had the same problem again.

Comment 4

[Peter Weilbacher]

If you go to mozilla\toolkit\mozapps\installer and then remove the whole os2 subdir that you apparently already have using "rm -rfv os2" you should be able to check it out afresh with "cvs up -PACd" from the same directory.

Good that you point out bug 389781, though. Even with lxLite compression building size optimized might be worth a try. At the moment, if I compare 1.8 branch and trunk NSS DLLs are about 1.5x larger.

I'll add the COMSPEC tip to MDC.