Closed Bug 421662 Opened 15 years ago Closed 15 years ago

Rename TextRectangle* to ClientRect*

Categories

(Core :: DOM: CSS Object Model, defect)

Product:
Core
Component:
DOM: CSS Object Model
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(1 file)

trivial patch
39.99 KB, patch
sicking
: review+
sicking
: superreview+
damons
: approval1.9+
Details | Diff | Splinter Review 
by mutual agreement, we're renaming TextRectangle(List) to ClientRectangle(List). This won't really affect Web apps, which don't use these interface names, but our implementation names should match the spec to minimize future confusion. The best time to rename files and change the identifier names is now.
Flags: blocking1.9?
make that ClientRect and ClientRectList.
Summary: Rename TextRectangle* to ClientRectangle* → Rename TextRectangle* to ClientRect*
If there are no constants on these interfaces I wouldn't expect their names to show up at all, so not a blocker.

Though I suppose someone could muck around with the prototype in which case it would show up. Also seems like basically zero risk, so patch appreciated.
Flags: wanted1.9+
Flags: blocking1.9?
Flags: blocking1.9-
Attachment #308542 - Flags: superreview?(jonas)
Attachment #308542 - Flags: superreview?
Attachment #308542 - Flags: review?(jonas)
Attachment #308542 - Flags: review?
Attachment #308542 - Flags: superreview?(jonas)
Attachment #308542 - Flags: superreview+
Attachment #308542 - Flags: review?(jonas)
Attachment #308542 - Flags: review+
Comment on attachment 308542 [details] [diff] [review]
trivial patch

Very low risk renaming patch for maximum standards compliance goodness
Attachment #308542 - Flags: approval1.9?
Comment on attachment 308542 [details] [diff] [review]
trivial patch

a1.9+=damons
Attachment #308542 - Flags: approval1.9? → approval1.9+
Checked in
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
It looks like the removal of files wasn't checked in?
Following files are still in the tree but don't seem to be built:

dom/public/idl/base/nsIDOMTextRectangle.idl
dom/public/idl/base/nsIDOMTextRectangleList.idl
content/html/content/src/nsTextRectangle.h
content/html/content/src/nsTextRectangle.cpp
You need to log in before you can comment on or make changes to this bug.