42167 - make distclean doesn't descend into all subdirectories

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Stephan Niemz]

When running "make distclean" several Makefiles, .dep files and a few .so
files still stay there. It looks like make doesn't enter all subdirectories -
I would have to run "make distclean" by hand in those directories.

I'm attaching a list of files which "make distclean" left here.

Comment 1

[Stephan Niemz]

Attachment: List of files "make distclean" didn't remove here

Comment 2

[cls]

The problem is that calling allmakefiles.sh outside of configure doesn't work
since the standalone modules logic was added.  There are a couple of env
variables that are expected to be set but are not being inherited by the
sub-shell. 

Comment 3

[cls]

Fix has been checked in.

Comment 4

[Stephan Niemz]

    Sorry to bother you again, but there are still several Makefiles and
.deps dirs which don't get deleted. And there are some .so and .a files,
too. Maybe this is correct, because they are in directories which shouldn't
be there any more, or have been renamed, but I'm not sure.

    I'm going to attach a list of files. You can see from the modification
time that a few are newly created (by the make distclean!) and most are
quite old. I got this list by running

	find -name .cvsignore | xargs rm -f
	cvs -n update -I! -ICVS 2>&1 | tee cvsupdate.log
	grep  '^\? ' cvsupdate.log | cut -c3- | xargs ls -ld >attached-list

    Of course a new checkout is required to fetch the .cvsignore files
again after this.

Comment 5

[Stephan Niemz]

Attachment: List of files CVS doesn't know about, i. e. which are still left after make distclean

Comment 6

[cls]

Can you provide a complete build log, from checkout to distclean?  I just tested
again here and it succesfully removes all generated files from my build tree.

Comment 7

[Stephan Niemz]

Attachment: Log from the last "make distclean" leading to the above list

Comment 8

[Stephan Niemz]

    As I said, many of the files are staying there for several weeks now.
I think after a checkout, build and distclean they would still be there
because they aren't covered by any Makefile any more. And if I would delete
them by hand or check out the whole tree in an empty directory again, they
probably wouldn't appear again. So maybe this is a non-issue.

    But there are also a few files which were modified today and which have
been created by the configure that was started by the distclean, namely

-rw-rw-r--    1 stephan  src           531 Jun 14 19:23 .mozconfig.mk
-rw-rw-r--    1 stephan  src            99 Jun 14 19:24
nsprpub/config/my_config.mk
-rw-rw-r--    1 stephan  src           142 Jun 14 19:24
nsprpub/config/my_overrides.mk

    And sorry, but I would rather not want to pull the whole tree again
over my slow 64kbit ISDN line, unless it is really necessary.

Comment 9

[cls]

Ok, I did miss .mozconfig.mk & the my_conf* files because I used a different
method to build. (Namely, not using client.mk nor the classic nspr build.)  And
you're right, previously, we would not have properly removed Makefiles if the
build config had changed.  Now we do if you run a distclean before you re-run
configure.  So that would explain the jpeg, zlib, libpng, unix_services and a
few other files. Remove those files manually and see if you can reproduce the
problem from a fresh tree.

Comment 10

[Stephan Niemz]

    No, I can't reporduce it, but now I get different filed staying threre:
nsprpub/config/nfspwd and directories named Linux2.2.14_x86_PTH_OPT.OBJ in
several places. The .mozconfig.mk & the my_conf* files are still there,
too.

Comment 11

[Stephan Niemz]

Attachment: New list of leftover files

Comment 12

[cls]

Again I am unable to reproduce your file list.   I pulled a fresh tree, ran
./configure && make export && make distclean inside the source tree.  With the
exception of the .mozconfig* files, all of the generated files were removed.

The _PTH_OPT.OBJ files you mentioned are from nspr.  Best I can tell, it
properly removes all generated files with the distclean target.  Are you sure
those files were not left over from a previous build?

What are the exact commands you are using to build?  

Comment 13

[cls]

*** Bug 44245 has been marked as a duplicate of this bug. ***

Comment 14

[Jonathan Lennox]

Attachment: Perl script to detect lingering files

Comment 15

[cls]

Please attach the unallmakefiles.sh generated by configure and a log of the
'make distclean' command.  

Comment 16

[Jonathan Lennox]

This was an M16 build -- I'll try an M17-current and see if the problem remains.

(I think my Perl script should be useful to detect the problem in the future,
even if your unallmakefiles fix has things happy for now.)

Comment 17

[Jonathan Lennox]

I checked out the 06/30/2000 16:38:09 PDT tree, did ./configure, and then make 

distclean.  The only files that remained were:



mozilla/nsprpub/config/my_config.mk

mozilla/nsprpub/config/my_overrides.mk



I'll try doing a full checkout/build/clean cycle, and see if anything additional 

gets left over.

Comment 18

[cls]

I've checked in fixes to remove the leftover my_*.mk files and the .mozconfig*
files.  Marking fixed.

Comment 19

[Jon Granrose]

verified.