421675 - remove period after "Keep my history for at least xx days"

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Steffen Wilberg]

In Options->Privacy->History, the "Keep my history for at least xx days" label has a period (".") at the end, which should be removed since it is the only one in the whole Options window.

Comment 1

[Steffen Wilberg]

Attachment: remove the period

Changing the value, the entity and the l10n note. I thought about leaving the entity alone, but most locales have picked up this glitch.

Picking Seth as reviewer since he missed this...

Comment 2

[Steffen Wilberg]

Attachment: correct patch

Sorry, this is the right patch.

Comment 3

[Seth Spitzer]

I don't think you need to change the entity name if you are just fixing punctuation.

please seek review from dietrich (or beltzner as this is late-l10n. I'm not sure the policy right now.)

Comment 4

[Dietrich Ayala (:dietrich)]

[08:43am] dietrich: rename or no rename for non-semantic changes?
[08:46am] Pike: well, steffen has the whole rationale there. http://mxr.mozilla.org/l10n/search?
[08:47am] Pike: most locales have it, and nobody would care
[08:47am] Pike: so either way is fine 
[08:47am] Pike: I'd probably a- it as a string change per-se, though
[08:49am] Pike: I'd a- it with the entity key change, and I'd a+ it without, pending a post to .l10n. But that's me, and not beltzner, who's really making the call

It seems there's no explicit policy wrt to renaming entities for non-semantic changes. Sounds Seth is right, and renaming is not necessary in this case.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 312977 [details] [diff] [review]
correct patch

Might as well flip the entity.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 312977 [details] [diff] [review]
correct patch

a1.9=beltzner

Comment 7

[Reed Loden [:reed]]

Checking in browser/locales/en-US/chrome/browser/preferences/privacy.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/privacy.dtd,v  <--  privacy.dtd
new revision: 1.20; previous revision: 1.19
done
Checking in browser/components/preferences/privacy.xul;
/cvsroot/mozilla/browser/components/preferences/privacy.xul,v  <--  privacy.xul
new revision: 1.29; previous revision: 1.28
done

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008040504 Minefield/3.0pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008040504 Minefield/3.0pre

-and-

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008040504 Minefield/3.0pre