Closed Bug 421701 Opened 16 years ago Closed 16 years ago

Don't change Bookmark Contextual dialog width when clicking Folder/tags expander

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED DUPLICATE of bug 413053

People

(Reporter: adelfino, Unassigned)

References

Details

(Keywords: polish, Whiteboard: [polish-easy][polish-interactive][polish-high-visibility])

Attachments

(3 files, 1 obsolete file)

Page Bookmarked window with both expanders collapsed.
7.62 KB, image/png
Details
Page Bookmarked window with folder expanded.
10.21 KB, image/png
Details
Page Bookmarked window with tags expanded.
8.37 KB, image/png
Details 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008030801 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008030801 Minefield/3.0b5pre

Right now, the window is 4 pixels wider after clicking any of the expanders. I think the window should not change its width after clicking any of them.

See screenshot.

Reproducible: Always
Component: General → Theme
Version: unspecified → Trunk
QA Contact: general → theme
OS: Windows XP → All
Hardware: PC → All
Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041005 Minefield/3.0pre ID:2008041005

This issue isn't visible on OS X. No idea if this is Winstripe only. Aleksej, can you also see this with gnomestripe?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Don't change Page Bookmarked notification window width when clicking Folder/tags expander → Don't change Bookmark Contextual dialog width when clicking Folder/tags expander
Mozilla/5.0 (X11; U; Linux i686; eo; rv:1.9pre) Gecko/2008041104 Minefield/3.0pre

Yes, it moves left, and then becomes wider for the right side to be aligned again.
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → dao
Status: NEW → ASSIGNED

        Attachment #315268 -
        Flags: ui-review?(faaborg)

    
  

        Attachment #315268 -
        Flags: ui-review?(faaborg)

    
  
Assignee: dao → nobody
Status: ASSIGNED → NEW

    
    

    
  
I assume now is too late to do anything on this for Firefox 3.0.0, right?

    
    

    
  
Dão, you want to request (ui-)review for this one?

    
    

    
  
Feel free to pick it up, I'm currently not working on it.

    
    

    
  
The patch still applies on trunk...

    
    

    
  
Comment on attachment 315268 [details] [diff] [review]
patch

Not having the left and right borders looks kind of weird, but then again the panel width changing constantly drives me nuts!  Let's see what beltzner thinks here...

        Attachment #315268 -
        Flags: ui-review?(beltzner)

    
    

    
  
this bug is eligible for bug 462081
Keywords: polish
Whiteboard: [polish-easy][polish-interactive]
Whiteboard: [polish-easy][polish-interactive] → [polish-easy][polish-interactive][polish-high-visibility]

    
    

    
  
i think a better way to fix this would be fix bug 413053
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → VERIFIED

    
    

    
  
Comment on attachment 315268 [details] [diff] [review]
patch

obsoleting, should be wfm now

        Attachment #315268 -
        Attachment is obsolete: true

        Attachment #315268 -
        Flags: ui-review?(beltzner)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: