Closed Bug 421721 Opened 13 years ago Closed 13 years ago

remove tabs-bottom-spacer, it's unused

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta5

People

(Reporter: dao, Assigned: dao)

References

()

Details

(Keywords: addon-compat, Whiteboard: legacy code, added to tabbrowser.xml in bug 395402)

Attachments

(2 files)

Attached patch diff -wSplinter Review
No description provided.
Attachment #308187 - Flags: review?(mconnor)
Attached patch full patchSplinter Review
Blocks: 395402
Summary: tabs-bottom-spacer is unused → remove tabs-bottom-spacer, it's unused
395402 didn't add or remove any anonymous content at all...
No longer blocks: 395402
Bug 395402 did add <xul:spacer class="tabs-bottom-spacer"/> to tabbrowser.xml.
Blocks: 395402
Status: NEW → ASSIGNED
Comment on attachment 308187 [details] [diff] [review]
diff -w

r+a=me on some cruft removal.  Please post to dev themes, in case someone is using this for some strange reason...
Attachment #308187 - Flags: review?(mconnor)
Attachment #308187 - Flags: review+
Attachment #308187 - Flags: approval1.9+
(In reply to comment #3)
> Bug 395402 did add <xul:spacer class="tabs-bottom-spacer"/> to tabbrowser.xml.
I believe I've already said that it didn't add any new anonymous content. If you had actually looked at the patch from that bug, you'd notice that it simply did a wholesale replacement of one binding's content with another's in order to get rid of unnecessary extra files. There's no relation at all between 395402 and the "new" contents of the binding.
No longer blocks: 395402
Yeah, don't worry, I looked at the patch. :)
tabs-bottom-spacer was moved from theme-specific bindings (where it made sense long ago) to the cross-platform tabbrowser.xml. This bug blocking bug 395402 is a useful reference for others in order to understand this bug's history.
Blocks: 395402
Keywords: late-compat
I've sent a message to m.d.themes.
Blocks: 395402
Keywords: checkin-needed
Whiteboard: legacy code, added to tabbrowser.xml in bug 395402
Checking in browser/base/content/tabbrowser.xml;
/cvsroot/mozilla/browser/base/content/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.267; previous revision: 1.266
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta5
You need to log in before you can comment on or make changes to this bug.