421738 - Spidermonkey fails to build with GCC 4.2 (jslock.cpp uses memset() without including string.h)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Sebastian Redl]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9b4pre) Gecko/2008022119 Firefox/3.0b4pre
Build Identifier: 

In the mozilla-central hg branch, the Spidermonkey sources have been changed to C++ from C. The new jslock.cpp file uses the memset() function, but fails to include the required <string.h> header; nor does it include it indirectly. Thus, compilation fails under GCC 4.2.

Reproducible: Always

Steps to Reproduce:
1. Check out latest hg mozilla-central.
2. Run python client.py checkout
3. Build
Actual Results:  
Fails with error message: "memset not declared".

Expected Results:  
Should compile.

Comment 1

[Sebastian Redl]

Attachment: Trivial patch

This patch adds the missing include to jslock.cpp.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 308221 [details] [diff] [review]
Trivial patch

Thanks, attaching cvs diff output readable by patch(1) (this is essential) using -pu8 options (this is preferred, FYI). Will r+ that and ask for approval.

/be

Comment 3

[Brendan Eich [:brendan]]

Attachment: patch-ready version

Trivial porting patch, need rubber-stamp a+.

/be

Comment 4

[Sebastian Redl]

Sorry, that's what hg generates. Will use straight diff in the future.

Comment 5

[Mike Shaver (:shaver emeritus)]

Comment on attachment 308222 [details] [diff] [review]
patch-ready version

a=shaver

Comment 6

[Mike Shaver (:shaver emeritus)]

hg extdiff is a bit better, but yeah, we fight hg too.

Comment 7

[Brendan Eich [:brendan]]

Fixed:

js/src/jslock.c 3.83

/be