421751 - nsIProcess should not open command consoles when running batch files

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Dan Mills [:thunder]]

When nsIProcess is used to run a batch file in Windows a command prompt window will pop up.  Depending on how quickly the batch file runs it may only flash on screen for a short time.  See the weave forums for more info, e.g.:

https://labs.mozilla.com/forum/index.php/topic,574.msg2064.html#msg2064

Comment 1

[Dan Mills [:thunder]]

Attachment: patch v0

Thanks to dcamp for finding the flag I needed.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 308246 [details] [diff] [review]
patch v0

This is fine.  It only effects console apps but doesn't work on win9x.  But we need a comment why this flag is important.  add that, and r=dougt

Comment 3

[Dan Mills [:thunder]]

Comment on attachment 308246 [details] [diff] [review]
patch v0

Thanks Doug.  I'll add this:

/* The CREATE_NO_WINDOW flag is important to prevent console
 * windows from appearing.  This makes behavior the same on
 * all platforms.  This won't work on win9x, however.  The flag
 * will not have any effect on non-console applications.
 */

Requesting superreview from :bs.

Comment 4

[Dan Mills [:thunder]]

Comment on attachment 308246 [details] [diff] [review]
patch v0

Removing accidental a?

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 308246 [details] [diff] [review]
patch v0

sr=mconnor

Comment 6

[Dan Mills [:thunder]]

Comment on attachment 308246 [details] [diff] [review]
patch v0

Thanks Mike.
Requesting a1.9...

I'd really like to get this into Fx3, it's super small and low-risk, and will make my life easier in Weave.

Let me know if you need any more info for why we want this now rather than wait.

Comment 7

[Damon Sicore (:damons)]

Comment on attachment 308246 [details] [diff] [review]
patch v0

a1.9+=damons

Comment 8

[Dan Mills [:thunder]]

Committed:

/cvsroot/mozilla/xpcom/threads/nsProcessCommon.cpp,v  <--  nsProcessCommon.cpp
new revision: 1.25; previous revision: 1.24

Comment 9

[Adam Lesien]

this is change to previous behavior.
with my extenstion I would like to open command prompt window or see batch output and now it's impossible?

...
path = System32+"cmd.exe"
var file = Components.classes["@mozilla.org/file/local;1"]
				.createInstance(Components.interfaces.nsILocalFile);
file.initWithPath(path);
var process = Components.classes["@mozilla.org/process/util;1"]
				.createInstance(Components.interfaces.nsIProcess);

process.init(file);
var args = ["/k", "cd", "C:"];
process.run(false, args, args.length);
...

Comment 10

[Dan Mills [:thunder]]

You can use nsILocalFile.launch() to get the window:

let f = Components.classes["@mozilla.org/file/local;1"]
  .createInstance(Components.interfaces.nsILocalFile);
f.initWithPath("C:\\WINDOWS\\system32\\cmd.exe");
f.launch();

Comment 11

[Adam Lesien]

It's not the same. How can you pass parameters with f.launch()?

Comment 12

[Dan Mills [:thunder]]

You could run a batch file with all your parameters.

Comment 13

[Adam Lesien]

I am passing parameters to batch and other tools from FF.
With launch it is impossible.

Maybe better solution is to expose CREATE_NO_WINDOW flag in nsiProcess interface?!

Comment 14

[Dan Mills [:thunder]]

It's not impossible, just requires an extra batch file:

runcmd.bat:
start cmd %*

mozilla:
let file = Components.classes["@mozilla.org/file/local;1"]
  .createInstance(Components.interfaces.nsILocalFile); file.initWithPath("C:\\path\\to\\runcmd.bat");
let proc = Components.classes["@mozilla.org/process/util;1"]
  .createInstance(Components.interfaces.nsIProcess)
proc.init(file);
let args = ["/k", "echo", "hi"];
proc.run(false, args, args.length);

Works for me.

Comment 15

[Marcus]

This bug has found its way back into Shiretoko FF 3.5 beta.

I reported it as bug 485946:

https://bugzilla.mozilla.org/show_bug.cgi?id=485946