421933 - Map Enter to click as per HTML 5 spec

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Aaron Leventhal]

Now that tabindex="0" can be used on any element to make it focusable, it makes sense that it should be possible to trigger a click on those elements with the keyboard.

Matt May from UAAG suggested this as a best practice, and Opera already does it.

Comment 1

[Aaron Leventhal]

Attachment: Testcase

Comment 2

[Aaron Leventhal]

Attachment: Map unmodifed enter to click when not already consumed

Comment 3

[Mats Palmgren (inactive)]

Attachment: Testcase #2

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 308445 [details] [diff] [review]
Map unmodifed enter to click when not already consumed

This patch does not work well with form controls (Testcase #2),
causing double click/submit events.

I think this needs to be fixed:
1. add "&& !keyEvent->isMeta"
2. check if the target element is disabled
   (and possibly -moz-user-input:none as well?)
3. to avoid the duplicate events we need to add in all places that
   already handles VK_RETURN:
     "aVisitor.mEventStatus = nsEventStatus_eConsumeNoDefault".
   I did this for nsHTMLInputElement::PostHandleEvent() and it seemed
   to fix the problems with Testcase #2, but there might be more places
   that needs to be fixed.
4. I'd like to see some regressions tests.

Comment 5

[Mats Palmgren (inactive)]

FWIW, I think this new feature makes sense, but I'd like to hear
what others think.  Only Opera implements it, not Safari or IE8
as far as I can tell.

Comment 6

[Boris Zbarsky [:bzbarsky]]

If we can do it in a web-compatible way, this makes sense to me.

But if we do go with this, we should get it standardized.

Comment 7

[Aaron Leventhal]

I'll check with Hixie && WhatWG folks.

Comment 8

[Aaron Leventhal]

Hixie put it in -- paragraph 3 here:
http://www.w3.org/html/wg/html5/#interactive0

When activation is performed via some method other than clicking the pointing device, the default action of the event that triggers the activation must, instead of being activating the element directly, be to fire a click event on the same element. 

Comment 9

[Aaron Leventhal]

If someone else could take and finish this up that would be great.

Comment 10

[4esn0k]

link to same issue in Chrome:
https://code.google.com/p/chromium/issues/detail?id=122652

Comment 11

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.