421940 - support passing cache path to minidump_stackwalk

Status: RESOLVED FIXED

(Socorro :: General, task, P1)

Description

[(not currently active) Ted Mielczarek]

I landed my minidump_stackwalk symbol cache patch on a Breakpad branch:
http://google-breakpad.googlecode.com/svn/branches/processor-symbol-cache/

We should switch to using this in production. It's got unit tests, so I'm confident in the correctness. mento just hasn't had a chance to review it, so it hasn't landed in trunk yet. There may still be room for improvement in the code, I don't know.

Anyway, this adds a -c commandline option to minidump_stackwalk, which lets you specify the cache path. We should expose this through a config setting in the processor.

Comment 1

[Michael Morgan [:morgamic]]

Lars and Ted, could we work together on this and get this out there in the next 2 weeks?

Comment 2

[(not currently active) Ted Mielczarek]

Should be a super trivial patch.

Comment 3

[K Lars Lohn [:lars] [:klohn]]

The processor now has command line parameters that allow complete control over the invocation of the breakpad_stackwalk program.  “--stackwalkCommandLine
” defaults to “$minidump_stackwalkPathname -m $dumpfilePathname $processorSymbolsPathnameList 2>/dev/null”  Values of the substitution variables are inserted into the command line before the stackwalk command is invoked.  The substitution variables are simply other processor command line options or environment variables.  There are three valid forms for the substitution variables in the stackwalk command line: $variableName, $(variableName), %(variableName)s 

Example:
for caching version of minidump_stackwalk -
$minidump_stackwalkPathname -c /path/to/cache -m $dumpfilePathname $processorSymbolsPathnameList 2>/dev/null

it is acceptable to eschew all but the $dumpfilePathname subsitution variables:
/usr/local/bin/breakpad_stackwalk -c /path/to/cache -m $dumpfilePathname /mnt/socorro/symbols/symbols_ffx /mnt/socorro/symbols/symbols_sea /mnt/socorro/symbols/symbols_tbrd /mnt/socorro/symbols/symbols_sbrd /mnt/socorro/symbols/symbols_os 2>/dev/null

Comment 4

[Michael Morgan [:morgamic]]

Done, pushed this Wednesday.