support passing cache path to minidump_stackwalk

RESOLVED FIXED in 0.6

Status

Socorro
General
P1
normal
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: ted, Assigned: lars)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

10 years ago
I landed my minidump_stackwalk symbol cache patch on a Breakpad branch:
http://google-breakpad.googlecode.com/svn/branches/processor-symbol-cache/

We should switch to using this in production. It's got unit tests, so I'm confident in the correctness. mento just hasn't had a chance to review it, so it hasn't landed in trunk yet. There may still be room for improvement in the code, I don't know.

Anyway, this adds a -c commandline option to minidump_stackwalk, which lets you specify the cache path. We should expose this through a config setting in the processor.
Lars and Ted, could we work together on this and get this out there in the next 2 weeks?
Assignee: nobody → lars
Priority: -- → P1
Target Milestone: --- → 0.6
(Reporter)

Comment 2

10 years ago
Should be a super trivial patch.
(Assignee)

Comment 3

10 years ago
The processor now has command line parameters that allow complete control over the invocation of the breakpad_stackwalk program.  “--stackwalkCommandLine
” defaults to “$minidump_stackwalkPathname -m $dumpfilePathname $processorSymbolsPathnameList 2>/dev/null”  Values of the substitution variables are inserted into the command line before the stackwalk command is invoked.  The substitution variables are simply other processor command line options or environment variables.  There are three valid forms for the substitution variables in the stackwalk command line: $variableName, $(variableName), %(variableName)s 

Example:
for caching version of minidump_stackwalk -
$minidump_stackwalkPathname -c /path/to/cache -m $dumpfilePathname $processorSymbolsPathnameList 2>/dev/null

it is acceptable to eschew all but the $dumpfilePathname subsitution variables:
/usr/local/bin/breakpad_stackwalk -c /path/to/cache -m $dumpfilePathname /mnt/socorro/symbols/symbols_ffx /mnt/socorro/symbols/symbols_sea /mnt/socorro/symbols/symbols_tbrd /mnt/socorro/symbols/symbols_sbrd /mnt/socorro/symbols/symbols_os 2>/dev/null
Done, pushed this Wednesday.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.