More C++ casts required for Windows only, especially overloaded pow() and log10()

RESOLVED FIXED in mozilla1.9beta5

Status

()

Core
JavaScript Engine
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

Trunk
mozilla1.9beta5
x86
Windows XP
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 308459 [details] [diff] [review]
more casts to make C++ happy, rev. 1

These were build errors for me on mozilla-central, but the tinderbox is green. Anyway, these look correct and useful in any case.
Attachment #308459 - Flags: review?(crowder)

Updated

10 years ago
Attachment #308459 - Flags: review?(crowder) → review+
(Assignee)

Comment 1

10 years ago
Comment on attachment 308459 [details] [diff] [review]
more casts to make C++ happy, rev. 1

very low-risk
Attachment #308459 - Flags: approval1.9?
Comment on attachment 308459 [details] [diff] [review]
more casts to make C++ happy, rev. 1

a1.9+=damons
Attachment #308459 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Assignee: general → benjamin
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Checking in js/src/jsinterp.c;
/cvsroot/mozilla/js/src/jsinterp.c,v  <--  jsinterp.c
new revision: 3.471; previous revision: 3.470
done
Checking in js/src/jsutil.c;
/cvsroot/mozilla/js/src/jsutil.c,v  <--  jsutil.c
new revision: 3.30; previous revision: 3.29
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta5

Updated

10 years ago
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.