Closed Bug 421955 Opened 14 years ago Closed 14 years ago

combining mark at start of text run rendered as NUL hex box or garbage

Categories

(Core :: Graphics, defect, P2)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.9beta5

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(2 files)

Attached file testcase
No description provided.
Flags: blocking1.9?
Priority: -- → P2
Target Milestone: --- → mozilla1.9beta5
Comment on attachment 308470 [details] [diff] [review]
use a source consistent with sourceOffset

oops
Attachment #308470 - Flags: review?(roc) → review+
Attachment #308470 - Flags: approval1.9?
Comment on attachment 308470 [details] [diff] [review]
use a source consistent with sourceOffset

a1.9+=damons
Attachment #308470 - Flags: approval1.9? → approval1.9+
Flags: in-testsuite?
What's the best way to test this?  Can the testcase be compared to something else, or should we just test that it renders the same way each time?

== 421955-1.html 421955-1.html
I don't think testing for rendering the same way each time is enough for the test case here.

I was wondering about comparing testcases each with two words, the second of which begins with a combining mark.  One of the testcases would need a (CSS?) trick to make the second word begin a new text run.

Perhaps the trick could be to specify a slightly different font-family list where the first family is a garbage family name that doesn't exist.  Any better ideas?
Why not?  Before the patch, it wasn't rendering the same way each time (wrt reloads).
Fwiw, bug 421234 was also fixed by this patch and should be easy to reftest.
Blocks: 421234
That would work. But why couldn't you put the second word in its own DIV to get the second textrun?
(In reply to comment #10)
> But why couldn't you put the second word in its own DIV to get
> the second textrun?

Maybe, if that could still render the same as without the DIV (when the mark is not at the beginning of the text run).

(In reply to comment #7)
> I was wondering about comparing testcases each with two words, the second of
> which begins with a combining mark.  One of the testcases would need a (CSS?)
> trick to make the second word begin a new text run.

But I'm starting to think that this is not a good idea.
There is a good chance that the mark combining with the space (in the single text run case) could change the width of the space.

(In reply to comment #8)
> Why not?  Before the patch, it wasn't rendering the same way each time (wrt
> reloads).

You are right.
"== 421955-1.html 421955-1.html" would provide some level of testing.
Flags: blocking1.9?
You need to log in before you can comment on or make changes to this bug.