Closed
Bug 421992
Opened 16 years ago
Closed 16 years ago
Fix compile warnings in nsPluginHostImpl.cpp
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(1 file)
|
2.14 KB,
patch
|
jst
:
review+
jst
:
superreview+
jst
:
approval1.9+
|
Details | Diff | Splinter Review |
A couple of warnings from bug 420285 I think. The second probably crashes with PR_LOG enabled. nsPluginHostImpl.cpp: In member function 'nsresult nsPluginTag::EnsureMembersAreUTF8()': nsPluginHostImpl.cpp:996: warning: comparison between signed and unsigned integer expressions nsPluginHostImpl.cpp: In member function 'nsresult nsPluginHostImpl::ReadPluginInfo()': nsPluginHostImpl.cpp:5871: warning: cannot pass objects of non-POD type 'class nsCString' through '...'; call will abort at runtime
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #308532 -
Flags: superreview?(jst)
Attachment #308532 -
Flags: review?(jst)
|
||
Updated•16 years ago
|
Attachment #308532 -
Flags: superreview?(jst)
Attachment #308532 -
Flags: superreview+
Attachment #308532 -
Flags: review?(jst)
Attachment #308532 -
Flags: review+
Attachment #308532 -
Flags: approval1.9+
|
|
||
Comment 2•16 years ago
|
||
Fix checked in, thanks for the fix!
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•