422050 - position test failure

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Andrew Schultz]

Attachment: testcase

I hit test failures with test_position.  I don't see anything wrong with the test, but I'm not sure I understand the failures.  The failures are:

not ok - button1 client rect right got 101, expecting 99
not ok - button1 scrolled client rect right got 101, expecting 99
not ok - button1 scrolled client rect right got 101, expecting 99

Assuming I didn't remove anything important, I've attached a simpler testcase for the first failure (prints "got 100.88333129882812 (fail)").

Comment 1

[Neil Deakin]

The tests are not accounting for some margin/border/padding that your theme has. The testcase here for instance isn't accounting for the button's margin.
 

Comment 2

[Andrew Schultz]

Any pointers for what to look at to identify the problem?  Or... put another way: why should getBoundingClientRect().right be 99?

Comment 3

[Neil Deakin]

Er, I just said in the last comment. Are you asking about this testcase or test_position.xul? If the latter, you would need to look in the dom inspector to find out what element had an extra border/margin/padding and change the test to account for it.

Comment 4

[Andrew Schultz]

Attachment: patch

default min-width on a button is 6.3em, which works out to 92px for me.

Comment 5

[Andrew Schultz]

Attachment: set minheight too

My other box has an abnormally high line-height and this seems to translate to a minimum height for the button.  Overriding minheight gets the test passing there.

Comment 6

[Andrew Schultz]

fixed