422082 - Crash reporter remains open after submitting data

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008031104 Minefield/3.0b5pre ID:2008031104

Steps:

1, Trigger crash (eg with Crash Me Now extension)
2, Leave default settings (in particular Submit to Mozilla is ticked)
3, Click on Restart Firefox button

Expected results: Crash Reporter closes after submitting report

Actual results: Crash Reporter stays open with text (to the effect of) crash submitted successfully.

Maybe notification is good here, but it seems like it should auto close after a short time.

Comment 1

[(not currently active) Ted Mielczarek]

Fallout from bug 421841. My fault.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: fix the method to be the right kind

Yeah, I told beltzner to make this change and it was wrong.

shaver's right, we need to figure out how to unit test this.

Comment 3

[Damon Sicore (:damons)]

Comment on attachment 308609 [details] [diff] [review]
fix the method to be the right kind

a1.9+=damons

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

We don't have to modify the calls to closeMeDown so that instead of sending withObject:nil they go back to sending withObject:self?

Comment 5

[(not currently active) Ted Mielczarek]

No, we're not actually using the parameter that's passed in, but ObjC expects the selector to take a single parameter. I tested this patch, it works.

Checked in.