Closed
Bug 422113
Opened 17 years ago
Closed 17 years ago
EnsureLegalActivity crashes by opening Venkman
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: kayjay, Assigned: mrbkap)
References
()
Details
(Keywords: crash, fixed1.9.0.2, regression, Whiteboard: fixed on 1.8 by 441087)
Attachments
(2 files, 1 obsolete file)
|
852 bytes,
patch
|
mrbkap
:
review+
mrbkap
:
superreview+
|
Details | Diff | Splinter Review |
|
940 bytes,
patch
|
jst
:
review+
jst
:
superreview+
samuel.sidler+old
:
approval1.9.0.2+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12
Current 1.8 branch code base (10.03.2008) crashes always by opening Venkman in XPCNativeWrapper::EnsureLegalActivity () because missing check for script security manager pointer.
I have my own application based on 1.8 but I am pretty sure that this error is general and can be reproduced always.
EnsureLegalActivity was added recently and it does not check pointer returned by GetAppropriateSecurityManager () - this pointer check is performed in other places.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Assignee: nobody → mrbkap
Component: General → XPConnect
Keywords: crash,
regression
Product: Firefox → Core
QA Contact: general → xpconnect
Version: unspecified → Trunk
Attachment #308714 -
Flags: review?(mrbkap)
|
Assignee | |
Comment 3•17 years ago
|
||
We can do better on the trunk (and on the 1.9.x branch) by using XPCWrapper::GetSecurityManager to avoid the QI.
Attachment #308714 -
Attachment is obsolete: true
Attachment #326275 -
Flags: superreview?(jst)
Attachment #326275 -
Flags: review?(jst)
Attachment #308714 -
Flags: review?(mrbkap)
|
|
Assignee | |
Comment 4•17 years ago
|
||
Comment on attachment 308715 [details] [diff] [review]
branch
I don't know what we're doing with the 1.8 branch, but this is fine to land there if people want.
Attachment #308715 -
Flags: superreview+
Attachment #308715 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Updated•17 years ago
|
Attachment #326275 -
Flags: superreview?(jst)
Attachment #326275 -
Flags: superreview+
Attachment #326275 -
Flags: review?(jst)
Attachment #326275 -
Flags: review+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Fixed on trunk in changeset 631c0cb99782.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•17 years ago
|
||
Comment on attachment 326275 [details] [diff] [review]
Better trunk patch
This might not be necessary, but it's an easy fix for a crash bug in Venkman.
Attachment #326275 -
Flags: approval1.9.0.2?
|
||
Updated•17 years ago
|
Flags: in-testsuite?
|
|
||
Comment 7•17 years ago
|
||
Any way to get an automated test for this?
|
|
Assignee | |
Comment 8•17 years ago
|
||
At the moment, all of our automated test environments have security managers, so no.
|
|
||
Comment 9•17 years ago
|
||
Comment on attachment 326275 [details] [diff] [review]
Better trunk patch
Lame.
Approved for 1.9.0.2. Please land in CVS. a=ss
|
|
||
Updated•17 years ago
|
Attachment #326275 -
Flags: approval1.9.0.2? → approval1.9.0.2+
|
|
Assignee | |
Comment 11•17 years ago
|
||
The 1.8 branch patch for bug 441087 rolls this bug into it.
You need to log in
before you can comment on or make changes to this bug.
Description
•