42220 - undo/redo not coalescing properly

Status: NEW

(Core :: DOM: Editor, defect, P4)

Description

[Kathleen :Brade]

When I type the following letters:
 bold 
and then press
 command-b (control-b on windows)
and then type the following keys:
 bold
and then press command-b again (to remove the bold state)
and then type the following keys:
 bold

I expect to see bold BOLD bold (where BOLD is actually <b>bold</b>).

I then choose Undo

I expect my last typing of "bold" to be removed.  Instead all of the text I've 
typed is removed.

Possibly related to this is if I redo (after an undo) and continue typing, I 
still undo the insertion of all the text typed

I expect that shortcut keys (like Command-b) and transaction events themselves 
(undo/redo) will break the coalescing of typing.

Comment 1

[kinmoz]

This is probably due to the fact that we stop coalescing based on editing
actions. In your example, you are hitting control-b while the selection is
collapsed (a caret) so there is no editing action that is triggered. Instead the
type in state is modified so that the next editing action knows what style to
use.

I suppose we should be terminating type in coalescing when the type in state
changes to something different then what was used during the last type in event.

Comment 2

[Joe Francis]

this is per 4.x behavior

Comment 3

[sujay]

verified in 6/13 build.

Comment 4

[Kathleen :Brade]

reopening bug

Comment 5

[Kathleen :Brade]

I'd rather keep this bug around; I don't think it's "invalid."

Resolve it as Later or set it to Milestone Future if we don't aren't going to fix 
it right away.

I believe the reason 4.x works the way it does is because it didn't have multi-
level undo.  We have multi-level undo and should provide the undo/redo at a finer 
level than 4.x did.  Also, I believe Word 97 for Windows works the way I've 
requested.  Sorry I don't have many other applications to compare to at the 
moment.

Comment 6

[Joe Francis]

I can make it work the way you want, I think, without too much trouble.  The 
issue is whether that's the way we want it to work.  It is a change from 4.x, so 
I believe it calls for extra consideration.

Comment 7

[rubydoo123]

setting keywords,status and milestone

Comment 8

[rubydoo123]

added correctness and nsbeta3+

Comment 9

[rubydoo123]

setting priority in status whiteboard

Comment 10

[rubydoo123]

due to the timeframe and the number of issues that need to be addressed, marking 
this as nsbeta3-, adding helpwanted and moving to future

Comment 11

[Joe Francis]

moz 0.9

Comment 12

[Joe Francis]

moving a bunch of 0.9 bugs to 0.9.1

Comment 13

[Joe Francis]

Futuring because I still don't know what the call is on this one.

Comment 14

[Kathleen :Brade]

MS Word 97 works more like what I want.  I haven't checked other applications 
yet.  

We should change our behavior to be more consistent with Word and other 
applications which allow multiple levels of undo and style changes.  We should 
stop coalescing of typing when the state changes.

Please reconsider for a mozilla 1.x milestone.

Comment 15

[Joe Francis]

097

Comment 16

[Syd Logan]

removing EDITORBASE-, is a P4 so it may not be done in time.

Comment 17

[Syd Logan]

triage team says minus

Comment 18

[Joe Francis]

the swami says: things that will not land in 099!

Comment 19

[Kevin McCluskey (gone)]

Moving bugs to Mozilla1.1 that are not EDITORBASE+.

Comment 20

[rubydoo123]

removing myself from the cc list

Comment 21

[Joe Francis]

The days of having a half dozen milestones out in front of us to divide bugs 
between seem to be gone, though I dont know why.  Lumping everything together as 
far out as I can.  I'll pull back things that I am working on as I go.

Comment 22

[Joe Francis]

[ushing these out as far as bugzilla will let me.  I'll pull them back as I work
on them.

Comment 23

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)