422258 - Let @cc be used to add new users to the CC list when editing bugs

Status: RESOLVED FIXED

(Bugzilla :: Incoming Email, enhancement)

Description

[Frédéric Buclin]

On bug creation, you have to use the @cc label to CC users. When editing bugs, you have to use @newcc. I never took care of this distinction, and probably other users won't remember the distinction either. We should be consistent and use @cc in both cases.

Comment 1

[Max Kanat-Alexander]

We should also let "newcc" keep working, but if they're both specified, "cc" should override "newcc". I think this is a small polish and a good API enhancement and I wouldn't object to taking it for 3.2, unless somehow it becomes a large patch (which I can't imagine it being).

Comment 2

[Frédéric Buclin]

email_in.pl contains:

    # Make it possible to remove CCs.
    if ($fields{'removecc'}) {
        $fields{'cc'} = [split(',', $fields{'removecc'})];
        $fields{'removecc'} = 1;
    }

and process_bug.cgi will do:

        $cc_add = join(' ',$cgi->param('newcc'));
        # We came from bug_form which uses a select box to determine what cc's
        # need to be removed...
        if (defined $cgi->param('removecc') && $cgi->param('cc')) {
            $cc_remove = join (",", $cgi->param('cc'));
        }

So 'cc' is used to remove users from the CC list (while on post_bug.cgi it's used to add users to it). Should we then close this bug as WONTFIX or allow the email sender to specify @cc anyway, and convert it to @newcc before @removecc is checked?

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> So 'cc' is used to remove users from the CC list (while on post_bug.cgi it's
> used to add users to it). Should we then close this bug as WONTFIX or allow the
> email sender to specify @cc anyway, and convert it to @newcc before @removecc
> is checked?

  We should let the user specify @cc and do whatever we have to do, behind the scenes, to make that work.

Comment 4

[Frédéric Buclin]

Attachment: patch, v1

Comment 5

[Frédéric Buclin]

Attachment: patch, v1.1

Same patch as above, but with updated POD.

Comment 6

[Max Kanat-Alexander]

Comment on attachment 318942 [details] [diff] [review]
patch, v1.1

Yeah, looks good. Although we should probably make it "$fields{'newcc'} = delete $fields{'cc} if $fields{'cc}".

Comment 7

[Frédéric Buclin]

Checking in email_in.pl;
/cvsroot/mozilla/webtools/bugzilla/email_in.pl,v  <--  email_in.pl
new revision: 1.17; previous revision: 1.16
done

Comment 8

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.2 in a patch on bug 432331.