Closed Bug 422268 Opened 17 years ago Closed 17 years ago

Valid dates do not show in RSS preview

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

x86
Windows XP
defect
Not set
major

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: neale, Unassigned)

References

()

Details

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031004 Minefield/3.0b5pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031004 Minefield/3.0b5pre Some valid RSS date formats do not show in the feed preview. Reproducible: Always Steps to Reproduce: 1. Add http://www.fridgemountain.com/services/givetake/rsssearchresults.do?submit=true&values(PostCode)=CB1&wantRange=30&values(wantFmCategory)=&categoryAttrName=wantFmCategory&scorePeriodDays=90&values(ItemStatus)=(null) Note closing bracket may need adding to URL 2. Item subjects appear, but dates do not 3. View source and you'll see dates such as <pubDate>Fri, 08 Feb 08 14:19:33 GMT</pubDate>, which, according to feedvalidator.org is valid. Expected Results: FF3 should support all valid date formats and all valid 3 letter timezone abbreviations. To have my site work with FF3b5, I've needed to amended the format of all dates to use 4 digit years AND the -0800 style format. I did this by changing from yy to yyyy and z to Z in my use of SimpleDateFormat thus giving dates as <pubDate>Mon, 30 Jul 2007 08:37:57 +0100</pubDate> in my items. The working version is to use: SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss Z") As far as getting FF3 compatible with FF2, I hope that this is now a case of supporting: SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss z") i.e. <pubDate>Mon, 30 Jul 2007 08:37:57 BST</pubDate> and SimpleDateFormat("EEE, dd MMM yy HH:mm:ss z") i.e. <pubDate>Mon, 30 Jul 07 08:37:57 BST</pubDate> The last of these is where I started, which does work in FF2.
I'm not at all sure what you mean by "which does work in FF2" since the feed preview in Fx2 didn't show dates at all - they were added by bug 358456 after 2.0. Nor should we parse BST as a timezone - RFC 822 had the lousy idea of allowing US timezone abbreviations, but it didn't compound it by allowing any abbreviation (BST may be your British Summer Time, but it's my Brazil Standard Time). The two digit year problem is because although the feed parser recognizes two digit years just fine, the preview page shows localized dates by passing the date string to JavaScript's Date(), and Date() does not tolerate two digit years. So fixing it would require giving FeedWriter's _parseDate function a copy of the parser's RFC 822 regex, so that dates which don't make it through Date() could be given the RFC 2822 interpretation of what the year ought to be and then passed through Date() again. Adding another copy of that ugly regex is a fragile thing to do, encouraging people to think that their two digit years are just fine (until 2050, when they become 1950) doesn't improve the quality of the world's feeds, and displaying it in the preview page isn't a functional requirement, just a nicety. I'd say wontfix.
Oops! Sorry Phil, I was getting mixed up on what had regressed, having been dealing with the Live Bookmarks end of it too. I agree on "won't fix". BST. No, I'm sure it must be "British". I'm sure our supreme leader (or prime minister as it used to be called) would tell you that Britain is still a great empire and being a tiny little island does not matter a jot, as we've got nukes ;) How about changing the British Summer Time acronym to make way for Brazilian Standard Time. We could have it as NAT: Nuclear Armageddon Time ? :O)
Status: UNCONFIRMED → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.