422270 - Firefox leaks with the Yandex Toolbar installed

Status: RESOLVED INCOMPLETE

(Core :: General, defect, P2)

Description

[Carsten Book [:Tomcat]]

Attachment: leak log

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031113 Firefox/3.0b5pre ID:2008031113

Steps to reproduce: 
- Install the Yandex Toolbar from http://bar.yandex.ru/firefox/
- Click around on this Toolbar, open some windows, options
- Close Firefox

--> Leak

nsStringStats
 => mAllocCount:          55807
 => mReallocCount:         7888
 => mFreeCount:           54510  --  LEAKED 1297 !!!
 => mShareCount:          56098
 => mAdoptCount:           4067
 => mAdoptFreeCount:       4065  --  LEAKED 2 !!!

   0 TOTAL                                          25   664743  1469899    19838 ( 3471.14 +/-  3790.17)  4035530    22865 ( 5066.94 +/-  7568.55)

Comment 1

[Damon Sicore (:damons)]

+'ing w/ P2 as this is a very popular extension in Russia (like google toolbar).

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Tomcat, can you test this one to see if you can leak more than 2 nsGlobalWindows. If not we can fix this in a dot-release instead.

Comment 3

[Damon Sicore (:damons)]

Need an owner, ASAP.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Tomcat, would be great to get better testing here. See comment 2.

My list is getting short so I'll take this one.

Comment 5

[Carsten Book [:Tomcat]]

Attachment: leak log

(In reply to comment #4)
> Tomcat, would be great to get better testing here. See comment 2.
> 
> My list is getting short so I'll take this one.
> 

Hi Jonas, no 2 leaking Global Windows are the maximum i got leaking. So i think its okay to fix this for a dot release.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Excellent! Keeping a high priority since this is a very popular extension in some regions.

Comment 7

[Danil Ivanov]

Leaked when "Cities (Weather)" elements removing.
Fixed in 3.5.3+ (current version - 4.0.0).

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Danil: It would be great to know what you were doing that caused firefox to leak. Most likely whatever you were doing should not have caused a leak and the leak was due to a bug in firefox. It's great that you have been able to work around the leak, but it'd also be great if we could fix the bug in firefox so that it doesn't appear again.

Comment 9

[Danil Ivanov]

Attachment: Component with leak

When the "city" item is being added to the toolbar, a pointer to this item is added to gYaCity hash. gYaCity is loaded by nsIYaSearch component (from chrome/content/sub-scripts/ya_city.js with mozIJSSubScriptLoader.loadSubScript). When the "city" item is being deleted, its' pointer is not deleted from those hash.
A similar behaviour is shown by the component in attached script.

Comment 10

[Peter Van der Beken [:peterv]]

Yeah, components holding elements in global variables will leak. We've run into a bunch of these in frontend code, but no easy solution apart from changing the components code.

Comment 11

[Andrew McCreight [:mccr8]]

Filter on QUANTUMLEAK