42228 - Enable XSL hooks in default mozilla builds

Status: VERIFIED FIXED

(Core :: XML, defect, P3)

Description

[Nisheeth Ranjan]

We should enable the XSL hooks in the default mozilla builds after ensuring that 
Mozilla fails gracefully if a component implementing the nsIDocumentTransformer 
interface is not found.

Hey Peter, Axel, or Andreas:  any of you want to do this?

Comment 1

[Andreas Otte]

Currently I think we have to rethink the whole xsl hook stuff. Correct me if I'm
wrong: Transformiix currently returns a DOM-tree as respresentation of the
resulting document of the transformation. We put in the original xml document to
contain that new DOM-tree. We know nothing of the mimetype of the resulting
document. Can be text/xml, can be text/html, whatever. I think we need to create
the right document and the right ContentSink to layout the resulting document
correctly. I don't see how that can be acomplished with the current API of
nsTransformMediator::TryToTransform() and Transformer->TransformDocument. I
think we should wait with the activation unless it is really clear how the hooks
will work. Or is that just me don't getting it?

Comment 2

[Axel Hecht]

I have two issues with nsIDocumentTransformer:
Firstly, it would be great to do progressive transformation. Keith said, he had
some code to do that, what would we need to get the interface support that?

Secondly, for <xsl:include> we need the URL of the stylesheet, so should we move 
from nsIDOMElement to NSIDOMDocument?

Talking about the result doc, as far as I understood the XSLT specs, the output
must be XML, but you can set the namespace. Is this right?

Axel

Comment 3

[Axel Hecht]

added nsbeta2 keyword, changed platform/os to all.

Is XML the right component? Wouldn't XSLT be closer, easier to find?

Axel

Comment 4

[leger]

Putting on [nsbeta2-] radar. Not critical to beta2.

Comment 5

[Nisheeth Ranjan]

Putting on the nsbeta3 radar and setting target milestone to M18...

Comment 6

[Nisheeth Ranjan]

Marking nsbeta3- and re-assigning it to Peter who will be at Netscape for the 
next two weeks.  He can get this checked in through the process in place for 
external contributors: get a code review and approval from brendan/waterson.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

actually the resaulting document can be any mimetype and have any dtd. The three
"standard" output formats are text/xml, text/html and text/plain.

Comment 8

[Axel Hecht]

Hi Peter,
I give you an r=axel for switching the hooks on for solaris.
Tested the build with removed XSLT on the Viewer demos, and the xbl demos.
Applied css sheets went allright, without an error, as did applying xslt sheets.
Those of course just did nothin'

Axel

Comment 9

[Axel Hecht]

Added dependency on building on Windows.
Nisheeth, please review the patch in 52345.

Axel

Comment 10

[Jus]

Im having no problems on Win2K or linux with XSLT hooks in but no transformiix
library present.

Comment 11

[Peter Van der Beken]

I tested on Mac, so we covered the main platforms.
I'm attaching a patch to remove the MOZ_XSL defines from layout (and rdf). This 
turns on the hooks for XSLT in layout. Please review.
For Mac, nsIDocumentTransformer.idl needs to be added to the layoutIDL.mcp 
project.
After these changes, bug 51345 should be closed as invalid.

Comment 12

[Peter Van der Beken]

Attachment: Patch to remove the MOZ_XSL defines from layout and rdf

Comment 13

[Axel Hecht]

Hi,
I made a complete new build, with patch applied and --with-extionsions, and it
works. That is, I have tested the xml viewer demos 14, 15.
The xml slides on
http://www.mozilla.org/newlayout/xml/xml-devcon/slides/slide1.xml are
equally horked in the nightly as in my build. So I don't think that's our fault.
The XBL demos worked, I did some precheckin tests.

r=[e-mail]

Axel

Comment 14

[Peter Van der Beken]

XSLT hooks are now in default build.

Comment 15

[Chris Petersen]

Marking verified per last comments.