422326 - Visual glitch in site icon display part of location bar

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Jeff Walden [:Waldo]]

Attachment: Normal-sized icons

I'm seeing glitches in the top right part of the site icon area in the theme on OS X.  See this attachment and the following, one made on a bug on Bugzilla with normal-sized icons, the other with small icons enabled.

Word on IRC is this hasn't been seen/reported yet; I'm somewhat skeptical and expect this is a dup.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Small icons

Comment 2

[Asa Dotzler [:asa]]

I think this is the same issue as bug 419839 - Icon alignment issue on updated mac theme.  Basically the icon positioning is wrong and when its background color is changed to blue for secure sites (as opposed to transparent for normal sites) you see the glitch worse. Does that sound right? 

One of both of these should be plussed for blocking b3. It's a pretty "in your face" visual glitch on mac, maybe the most obvious flaw in our primary toolbar areas. 

Comment 3

[Johnathan Nightingale [:johnath]]

Attachment: Shift identity-icon-label padding up one pixel

This fixes the problem, but I'm not sure if kevin g already has a fix in the works elsewhere?

Comment 4

[Kevin Gerich]

Comment on attachment 309974 [details] [diff] [review]
Shift identity-icon-label padding up one pixel

I didn't get time to roll this into the latest Proto fixes. Thanks!

Comment 5

[Johnathan Nightingale [:johnath]]

Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.133; previous revision: 1.132
done