Visual glitch in site icon display part of location bar

RESOLVED FIXED

Status

()

Firefox
Theme
P2
normal
RESOLVED FIXED
10 years ago
7 years ago

People

(Reporter: Waldo, Assigned: johnath)

Tracking

({polish})

Trunk
x86
Mac OS X
polish
Points:
---
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

10 years ago
Created attachment 308806 [details]
Normal-sized icons

I'm seeing glitches in the top right part of the site icon area in the theme on OS X.  See this attachment and the following, one made on a bug on Bugzilla with normal-sized icons, the other with small icons enabled.

Word on IRC is this hasn't been seen/reported yet; I'm somewhat skeptical and expect this is a dup.
Flags: blocking-firefox3?
(Reporter)

Comment 1

10 years ago
Created attachment 308807 [details]
Small icons
Component: Location Bar and Autocomplete → Theme
QA Contact: location.bar → theme

Comment 2

10 years ago
I think this is the same issue as bug 419839 - Icon alignment issue on updated mac theme.  Basically the icon positioning is wrong and when its background color is changed to blue for secure sites (as opposed to transparent for normal sites) you see the glitch worse. Does that sound right? 

One of both of these should be plussed for blocking b3. It's a pretty "in your face" visual glitch on mac, maybe the most obvious flaw in our primary toolbar areas. 
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
(Assignee)

Comment 3

10 years ago
Created attachment 309974 [details] [diff] [review]
Shift identity-icon-label padding up one pixel

This fixes the problem, but I'm not sure if kevin g already has a fix in the works elsewhere?
Assignee: nobody → johnath
Status: NEW → ASSIGNED
Attachment #309974 - Flags: review?(kevin)

Comment 4

10 years ago
Comment on attachment 309974 [details] [diff] [review]
Shift identity-icon-label padding up one pixel

I didn't get time to roll this into the latest Proto fixes. Thanks!
Attachment #309974 - Flags: review?(kevin) → review+
(Assignee)

Comment 5

10 years ago
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.133; previous revision: 1.132
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.