In a couple of places (array_slice, and possible elsewhere) we mass copy the jsval vector to a new array, but if there are holes in the existing array segment then we can have some problems: 1) we need to ensure that COUNT is maintained correctly in the new array 2) if we have holes, we need to sample through to the prototype for values If we maintain COUNT correctly, then the holes test is either COUNT == LENGTH - 1 or COUNT == DENSE_LENGTH - 1, depending on whether we care about trailing holes or not. Need to audit those cases, and especially write tests. Could have web-compat issues.
--> Shaver then.
Shaver says this doesn't need to block - moving to .next..
Don't think we'll want this on 1.9.0.x if it could cause web-compat issues, but feel free to renominate.
9 years ago
A lot has changed, resolving WFM assuming there are no specific known issues.