Closed Bug 422360 Opened 13 years ago Closed 13 years ago

don't statically link browser components with crt if using jemalloc

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

Details

Attachments

(1 file)

We started statically linking the browser components to the CRT a while ago to work around stupid manifest issues. Now that we're building our own CRT with jemalloc, we could just link them to the CRT we're building when jemalloc is enabled. This way the browser components will get jemalloc love too.
Attachment #308832 - Flags: review?(benjamin)
Assignee: nobody → ted.mielczarek
Version: unspecified → Trunk
Attachment #308832 - Flags: review?(benjamin) → review+
Comment on attachment 308832 [details] [diff] [review]
don't statically link browser components when jemalloc is enabled

Might help perf or mem usage a little, I don't know, but it seems like the right thing to do.
Attachment #308832 - Flags: approval1.9?
Comment on attachment 308832 [details] [diff] [review]
don't statically link browser components when jemalloc is enabled

a1.9+=damons
Attachment #308832 - Flags: approval1.9? → approval1.9+
Checked in.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.